From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CEEEC433E0 for ; Mon, 18 May 2020 11:39:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 237F8206D4 for ; Mon, 18 May 2020 11:39:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lJXvCyg8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 237F8206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l36ba+vCUvk0LDEd3mHVLvqOx6VlavDVJCahiKCrcoc=; b=lJXvCyg8IDU4y6 6GUMXEjWxEaw8FEw/2AFNzzCIXNBjER+W3H2SzeegqTDw1eIizwSVkD9H6GsKShJjNw36ijFswwd2 DGoVgumey1JJUOP7QIFnGPAMk8t4aIsKla5XmUU1V8tmTERpH8osdTt58MKhDL57ODIhGBxmE3d3l 0k0slo5SAfBYGaFZF3/QNi4OlbK4bbp3ze6fT75qUHsTJfBDiTg8CYgJNazSCI7TrL5b4oes8vaYn Gug3gurGcFLzC3LN1NpI/gNTAxaSai9ZZrMNro037a47kQCr1KuGMa9S2sQ0+jzY98NBDjows153a z5hJHdvC3Q3OAZ+xPAdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jae6t-0005lX-S1; Mon, 18 May 2020 11:39:07 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jae6q-0005kl-Tp for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 11:39:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D38C9106F; Mon, 18 May 2020 04:39:03 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 73FB53F52E; Mon, 18 May 2020 04:39:01 -0700 (PDT) Date: Mon, 18 May 2020 12:38:58 +0100 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH 2/6] scs: Move accounting into alloc/free functions Message-ID: <20200518113858.GB1957@C02TD0UTHF1T.local> References: <20200515172756.27185-1-will@kernel.org> <20200515172756.27185-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515172756.27185-3-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_043905_004130_6B42E047 X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Jann Horn , Peter Zijlstra , Catalin Marinas , linux-kernel@vger.kernel.org, Mark Rutland , Sami Tolvanen , kernel-team@android.com, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 15, 2020 at 06:27:52PM +0100, Will Deacon wrote: > There's no need to perform the shadow stack page accounting independently > of the lifetime of the underlying allocation, so call the accounting code > from the {alloc,free}() functions and simplify the code in the process. > > Signed-off-by: Will Deacon > --- > kernel/scs.c | 45 +++++++++++++++++++++------------------------ > 1 file changed, 21 insertions(+), 24 deletions(-) One (super trivial) nit below, but regardless this looks like a sound and sensible cleanup, so: Reviewed-by: Mark Rutland > diff --git a/kernel/scs.c b/kernel/scs.c > index 5ff8663e4a67..aea841cd7586 100644 > --- a/kernel/scs.c > +++ b/kernel/scs.c > @@ -14,25 +14,35 @@ > static void *scs_alloc(int node) > { > + void *s = kmem_cache_alloc_node(scs_cache, GFP_SCS, node); > + > + if (!s) > + return NULL; Super trivial nit, but could we omit the line space between these two, to fit with usual style? Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel