From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D2EC433DF for ; Mon, 18 May 2020 12:16:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 221D120671 for ; Mon, 18 May 2020 12:16:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HrFJtwWw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 221D120671 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZM+87pCAE4mVM1OJ89rx9mFhNUEprc10ngGKJIuSg0I=; b=HrFJtwWwCE0PwS fE68dblytt/QnJRMSHkOVXOq5cLghFA4d1mkhAYM2G04Qk4ro3zkz1YpJy1ds+u5qKpVIHc5n97ti gKYfLboZTxXvne0vrzS5oq8T4qMCSe2MmNuNJLKt1Paz3NWujSdllgYjkHHxBCHN3Z3Bz/dzij3v+ 3VzwS1VCL8oZ3vMsZ4q1rWjeT/9ON4p7Lkmg78OCl7DFdjRM5EHjCUmaxKnHSV22V8Nn/hJV1HR9v y0AZEwYHrZHSf6Aw8bsa3aZmxh1gLvw4AmdK9Azyw439lLDaVk4HVp8vDdiNptNdsso4mIkTX8ihl bBWCX9fXGlznB7Gd344w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaegg-0006WX-Sw; Mon, 18 May 2020 12:16:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jaege-0006Vk-5Z for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 12:16:05 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C67C3106F; Mon, 18 May 2020 05:16:03 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 39DE73F305; Mon, 18 May 2020 05:16:01 -0700 (PDT) Date: Mon, 18 May 2020 13:15:58 +0100 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH 5/6] scs: Remove references to asm/scs.h from core code Message-ID: <20200518121558.GF1957@C02TD0UTHF1T.local> References: <20200515172756.27185-1-will@kernel.org> <20200515172756.27185-6-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200515172756.27185-6-will@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_051604_252679_2EBF1298 X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Jann Horn , Peter Zijlstra , Catalin Marinas , linux-kernel@vger.kernel.org, Mark Rutland , Sami Tolvanen , kernel-team@android.com, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 15, 2020 at 06:27:55PM +0100, Will Deacon wrote: > asm/scs.h is no longer needed by the core code, so remove a redundant > header inclusion and update the stale Kconfig text. > > Signed-off-by: Will Deacon With the corruption checks moved out of arch code this looks sound to me, so modulo my comments on the prior patch, assuming we factor that out: Reviewed-by: Mark Rutland Mark. > --- > arch/Kconfig | 4 ++-- > kernel/scs.c | 1 - > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/arch/Kconfig b/arch/Kconfig > index 45dfca9a98d3..2e6f843d87c4 100644 > --- a/arch/Kconfig > +++ b/arch/Kconfig > @@ -537,8 +537,8 @@ config ARCH_SUPPORTS_SHADOW_CALL_STACK > bool > help > An architecture should select this if it supports Clang's Shadow > - Call Stack, has asm/scs.h, and implements runtime support for shadow > - stack switching. > + Call Stack and implements runtime support for shadow stack > + switching. > > config SHADOW_CALL_STACK > bool "Clang Shadow Call Stack" > diff --git a/kernel/scs.c b/kernel/scs.c > index faf0ecd7b893..222a7a9ad543 100644 > --- a/kernel/scs.c > +++ b/kernel/scs.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > > static struct kmem_cache *scs_cache; > > -- > 2.26.2.761.g0e0b3e54be-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel