From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72592C433DF for ; Mon, 18 May 2020 13:37:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41020206D4 for ; Mon, 18 May 2020 13:37:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="C33v1H26" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41020206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AY69iPSeVEX3XYnF6qP9MLJdv1bMIVjeA0bSlafVPKk=; b=C33v1H26wuM9V5 4ZYEUxhF8jP4F2g0+E/N1soE19v+OgoGDEZIiIHeT9G4jRYNkjnBWX0BTf1xnfSRgYRL9YNYYvgmI JcFGTSZyzc5UauVYkbnLISEzSquALh0914ZLBwKlzYoyYi1YsBKLWIwIhzJO6zUR245lsT7lhgQ1Q NZLDQjtC9k/JCeNBRsojFIUl2HVocpT7ntrfNELfjyIBA5chrhQOzNcBei2SrmDhlTszahCOqU3sc CX4gpjtxnzxLe47i/XRsj3OHxSikNclaN0VJOFSvlTaZy8IFzNZ6zM+xQDhaTydFnVyjL0vI5vo/V QYjbsrzHAekFB1AttZdQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jafxP-0001fj-Ss; Mon, 18 May 2020 13:37:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jafxM-0001ex-Dm for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 13:37:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9C84A101E; Mon, 18 May 2020 06:37:21 -0700 (PDT) Received: from C02TD0UTHF1T.local (unknown [10.57.29.34]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 28C743F305; Mon, 18 May 2020 06:37:18 -0700 (PDT) Date: Mon, 18 May 2020 14:37:16 +0100 From: Mark Rutland To: Will Deacon Subject: Re: [PATCH 6/6] scs: Move DEFINE_SCS macro into core code Message-ID: <20200518133716.GD2787@C02TD0UTHF1T.local> References: <20200515172756.27185-1-will@kernel.org> <20200515172756.27185-7-will@kernel.org> <20200518121441.GE1957@C02TD0UTHF1T.local> <20200518132612.GE32394@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200518132612.GE32394@willie-the-truck> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_063724_505925_2858C050 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kees Cook , Jann Horn , Peter Zijlstra , Catalin Marinas , linux-kernel@vger.kernel.org, Mark Rutland , Sami Tolvanen , kernel-team@android.com, Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 18, 2020 at 02:26:12PM +0100, Will Deacon wrote: > On Mon, May 18, 2020 at 01:14:41PM +0100, Mark Rutland wrote: > > On Fri, May 15, 2020 at 06:27:56PM +0100, Will Deacon wrote: > > > Defining static shadow call stacks is not architecture-specific, so move > > > the DEFINE_SCS() macro into the core header file. > > > > > > Signed-off-by: Will Deacon > > > > I think that we'll have to pull this back into arch code if/when we deal > > with VMAP'd stacks, so I'm not sure this is worthwhile given the > > diffstat is balanced. > > I dunno, if another architecture wants to use this then having the stuff > in the core code makes sense to me. I also want to kill asm/scs.h entirely > and move our asm macros somewhere else where they're not mixed up with the > C headers. Thinking about it a bit further, we'd have to make bigger changes anyhow (to dynamically allocate), but given we can do that for regular stacks we can probably do something similar here. So no strong feelings either way on this patch. Reviewed-by: Mark Rutland Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel