From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C98BC433DF for ; Mon, 18 May 2020 17:09:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E55B320709 for ; Mon, 18 May 2020 17:09:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jC2FXP43"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="V8L67bWu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E55B320709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mE+rhMCqcRDaZjUTsKjiZ7xGvjMNrngb9K/+cNNKKqY=; b=jC2FXP43Nf8pWw EWvNrVwuY9nqBGGr6Hfa8gPf3oKY9jnkwTM2u/wj3FvWQE6QFAIwyOTIWaYm1132m5S10M3bWfceS eDeco1vNBCiH5xe+VYJqbWlr1PmijmRo3G4h4CwIpXIH1Zj7+IbMfuPP1kvn/NTNjZZUxiI+lX6d9 /puT7rahmcH1sizBToJqsXB2EcmJ0zDnLyzYDz6HjHWHMJdu6ZZYujnRajEmw8Fj2Q0oZoZ07RS+V c3ta1hOR/SfL3H/z2ewfoLQ3zGWuJypuMer5UspqvVtMoPvaToAcUVTvuafPVJbz8Ayod/K7umxfL xgrjY/4amta8EP0d+Qnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jajGs-0005FO-9F; Mon, 18 May 2020 17:09:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jajGl-0005A0-Qo for linux-arm-kernel@lists.infradead.org; Mon, 18 May 2020 17:09:41 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 09D96207E8; Mon, 18 May 2020 17:09:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589821779; bh=n3Jpm9TY854YSFMuLHwI+o4mk5x9P1AZ1cqMTatvLiQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V8L67bWuzL7d4qlbk48Otx7KYfhX0YF5j+C/FGzKYy7zntJaLwj/00MxWZCRYu2aR XIPzulnbJQY2ZCLWNImokFU8DgFzTt/RrzaMWPM28+kKmeRqyQ7uUlq5ynve8p7Hxt jU5kYqCUHm6B0xu6x5HEnbPzhPAVedwMsH5HctNs= Date: Mon, 18 May 2020 18:09:34 +0100 From: Will Deacon To: Anshuman Khandual Subject: Re: [PATCH V2] arm64/cpufeature: Drop open encodings while extracting parange Message-ID: <20200518170934.GT32394@willie-the-truck> References: <1589360614-1164-1-git-send-email-anshuman.khandual@arm.com> <20200518165958.GS32394@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200518165958.GS32394@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200518_100939_901522_E350C3FB X-CRM114-Status: GOOD ( 13.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Catalin Marinas , linux-kernel@vger.kernel.org, James Morse , Marc Zyngier , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 18, 2020 at 05:59:59PM +0100, Will Deacon wrote: > On Wed, May 13, 2020 at 02:33:34PM +0530, Anshuman Khandual wrote: > > Currently there are multiple instances of parange feature width mask open > > encodings while fetching it's value. Even the width mask value (0x7) itself > > is not accurate. It should be (0xf) per ID_AA64MMFR0_EL1.PARange[3:0] as in > > ARM ARM (0487F.a). Replace them with cpuid_feature_extract_unsigned_field() > > which can extract given standard feature (4 bits width i.e 0xf mask) field. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: James Morse > > Cc: kvmarm@lists.cs.columbia.edu > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-kernel@vger.kernel.org > > > > Signed-off-by: Anshuman Khandual > > --- > > Changes in V2: > > > > - Used cpuid_feature_extract_unsigned_field() per Mark > > > > Changes in V1: (https://patchwork.kernel.org/patch/11541913/) > > > > arch/arm64/kernel/cpufeature.c | 3 ++- > > arch/arm64/kvm/reset.c | 11 ++++++++--- > > 2 files changed, 10 insertions(+), 4 deletions(-) > > Acked-by: Will Deacon > > I'm assuming Marc will take this, but let me know if it should go via arm64 > instead (where we have a bunch of other cpufeature stuff queued). Hmm, but having just spotted [1], it looks like we might need a bit of co-ordination here. Marc? Will [1] https://lore.kernel.org/r/1589248647-22925-1-git-send-email-anshuman.khandual@arm.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel