From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7254C433E0 for ; Tue, 19 May 2020 12:06:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DD0D2081A for ; Tue, 19 May 2020 12:06:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sJcF3gpe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DD0D2081A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IF32foXCrl3o+XZ9aptDJ2AapUfJDd2ZDdqFU2mN2L0=; b=sJcF3gpejbgiaK TiF528vbprH8gLUa4LGBBblMuQQSgH/FS5fB8/ujsXA6IRWVGv9qAKJvWVdB2QOIbiYE1muRIwHj/ hrC8TlA2Y0Sclyug3L8VSqZFP302CbGHsSAqk27pb1q4kbOrgIn5tAs52lD3if8BriwXPnvjsrNi8 e5ks2NvfYp3paBw0zfkheUMie90CBc63J5tpmzkI2OHKKDSq83ZOxNpNEvvEEcKO724DUKsQVo5GP 0DI/W+Cp308yxGcwLy0Wb6mT/1ahnf1BwNFvvtIh6CU0EOpgVL3agzmyd8tQiCBCVvl/0NUS+8Q8y LVbNWbhnr7YW0XgzgjgA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb11J-00078C-4F; Tue, 19 May 2020 12:06:53 +0000 Received: from 8bytes.org ([81.169.241.247] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jb11G-00077V-E5 for linux-arm-kernel@lists.infradead.org; Tue, 19 May 2020 12:06:51 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 10E3E386; Tue, 19 May 2020 14:06:40 +0200 (CEST) Date: Tue, 19 May 2020 14:06:38 +0200 From: Joerg Roedel To: Wei Yongjun Subject: Re: [PATCH -next] iommu/sun50i: Fix return value check in sun50i_iommu_probe() Message-ID: <20200519120638.GG18353@8bytes.org> References: <20200519091857.134170-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200519091857.134170-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_050650_623208_0B1473C2 X-CRM114-Status: GOOD ( 10.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, iommu@lists.linux-foundation.org, Maxime Ripard , linux-kernel@vger.kernel.org, Hulk Robot , Chen-Yu Tsai , Maxime Ripard , Philipp Zabel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 19, 2020 at 09:18:57AM +0000, Wei Yongjun wrote: > In case of error, the function devm_platform_ioremap_resource() returns > ERR_PTR() not NULL. The NULL test in the return value check must be > replaced with IS_ERR(). > > Fixes: 4100b8c229b3 ("iommu: Add Allwinner H6 IOMMU driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/iommu/sun50i-iommu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel