* [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini
@ 2020-05-02 12:59 Adam Ford
2020-05-02 12:59 ` [PATCH] arm64: dts: imx8mm: Add support for micfil Adam Ford
2020-05-20 1:02 ` [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Shawn Guo
0 siblings, 2 replies; 6+ messages in thread
From: Adam Ford @ 2020-05-02 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Fabio Estevam, Will Deacon, Shawn Guo, Sascha Hauer,
aford, linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Catalin Marinas, Adam Ford
The i.MX8M Mini has SAI and micfil support but the drivers
are not being loaded.
This patch updates the defconfig to add support
CONFIG_SND_SOC_FSL_SAI and CONFIG_SND_SOC_FSL_MICFIL to support
these drivers.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 366857dfa9de..4e60e8a98b83 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -638,6 +638,8 @@ CONFIG_SND_HDA_TEGRA=m
CONFIG_SND_HDA_CODEC_HDMI=m
CONFIG_SND_SOC=y
CONFIG_SND_BCM2835_SOC_I2S=m
+CONFIG_SND_SOC_FSL_SAI=y
+CONFIG_SND_SOC_FSL_MICFIL=y
CONFIG_SND_MESON_AXG_SOUND_CARD=m
CONFIG_SND_SOC_SDM845=m
CONFIG_SND_SOC_ROCKCHIP=m
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] arm64: dts: imx8mm: Add support for micfil
2020-05-02 12:59 [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Adam Ford
@ 2020-05-02 12:59 ` Adam Ford
2020-05-20 1:03 ` Shawn Guo
2020-05-20 1:02 ` [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Shawn Guo
1 sibling, 1 reply; 6+ messages in thread
From: Adam Ford @ 2020-05-02 12:59 UTC (permalink / raw)
To: linux-arm-kernel
Cc: devicetree, Fabio Estevam, Will Deacon, Shawn Guo, Sascha Hauer,
aford, linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Catalin Marinas, Adam Ford
The i.MX8M Mini has supports the MICFIL digital interface.
It's a 16-bit audio signal from a PDM microphone bitstream.
The driver is already in the kernel, but the node is missing.
This patch adds the micfil node.
Signed-off-by: Adam Ford <aford173@gmail.com>
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index c63685ae80ee..d46e727fc362 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -339,6 +339,25 @@ sai6: sai@30060000 {
status = "disabled";
};
+ micfil: micfil@30080000 {
+ compatible = "fsl,imx8mm-micfil";
+ reg = <0x30080000 0x10000>;
+ interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX8MM_CLK_PDM_IPG>,
+ <&clk IMX8MM_CLK_PDM_ROOT>,
+ <&clk IMX8MM_AUDIO_PLL1_OUT>,
+ <&clk IMX8MM_AUDIO_PLL2_OUT>,
+ <&clk IMX8MM_CLK_EXT3>;
+ clock-names = "ipg_clk", "ipg_clk_app",
+ "pll8k", "pll11k", "clkext3";
+ dmas = <&sdma2 24 25 0x80000000>;
+ dma-names = "rx";
+ status = "disabled";
+ };
+
gpio1: gpio@30200000 {
compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio";
reg = <0x30200000 0x10000>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini
2020-05-02 12:59 [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Adam Ford
2020-05-02 12:59 ` [PATCH] arm64: dts: imx8mm: Add support for micfil Adam Ford
@ 2020-05-20 1:02 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-05-20 1:02 UTC (permalink / raw)
To: Adam Ford
Cc: devicetree, Will Deacon, Catalin Marinas, Sascha Hauer, aford,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
On Sat, May 02, 2020 at 07:59:47AM -0500, Adam Ford wrote:
> The i.MX8M Mini has SAI and micfil support but the drivers
> are not being loaded.
>
> This patch updates the defconfig to add support
> CONFIG_SND_SOC_FSL_SAI and CONFIG_SND_SOC_FSL_MICFIL to support
> these drivers.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 366857dfa9de..4e60e8a98b83 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -638,6 +638,8 @@ CONFIG_SND_HDA_TEGRA=m
> CONFIG_SND_HDA_CODEC_HDMI=m
> CONFIG_SND_SOC=y
> CONFIG_SND_BCM2835_SOC_I2S=m
> +CONFIG_SND_SOC_FSL_SAI=y
> +CONFIG_SND_SOC_FSL_MICFIL=y
Please enable them as 'm'.
Shawn
> CONFIG_SND_MESON_AXG_SOUND_CARD=m
> CONFIG_SND_SOC_SDM845=m
> CONFIG_SND_SOC_ROCKCHIP=m
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm: Add support for micfil
2020-05-02 12:59 ` [PATCH] arm64: dts: imx8mm: Add support for micfil Adam Ford
@ 2020-05-20 1:03 ` Shawn Guo
2020-10-28 12:10 ` Adam Ford
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2020-05-20 1:03 UTC (permalink / raw)
To: Adam Ford
Cc: devicetree, Will Deacon, Catalin Marinas, Sascha Hauer, aford,
linux-kernel, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam, linux-arm-kernel
On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote:
> The i.MX8M Mini has supports the MICFIL digital interface.
> It's a 16-bit audio signal from a PDM microphone bitstream.
> The driver is already in the kernel, but the node is missing.
>
> This patch adds the micfil node.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index c63685ae80ee..d46e727fc362 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -339,6 +339,25 @@ sai6: sai@30060000 {
> status = "disabled";
> };
>
> + micfil: micfil@30080000 {
Find a generic node name, audio-controller maybe?
Shawn
> + compatible = "fsl,imx8mm-micfil";
> + reg = <0x30080000 0x10000>;
> + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clk IMX8MM_CLK_PDM_IPG>,
> + <&clk IMX8MM_CLK_PDM_ROOT>,
> + <&clk IMX8MM_AUDIO_PLL1_OUT>,
> + <&clk IMX8MM_AUDIO_PLL2_OUT>,
> + <&clk IMX8MM_CLK_EXT3>;
> + clock-names = "ipg_clk", "ipg_clk_app",
> + "pll8k", "pll11k", "clkext3";
> + dmas = <&sdma2 24 25 0x80000000>;
> + dma-names = "rx";
> + status = "disabled";
> + };
> +
> gpio1: gpio@30200000 {
> compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio";
> reg = <0x30200000 0x10000>;
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm: Add support for micfil
2020-05-20 1:03 ` Shawn Guo
@ 2020-10-28 12:10 ` Adam Ford
2020-10-29 19:24 ` Krzysztof Kozlowski
0 siblings, 1 reply; 6+ messages in thread
From: Adam Ford @ 2020-10-28 12:10 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree, Will Deacon, Catalin Marinas, Sascha Hauer, aford,
Linux Kernel Mailing List, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Fabio Estevam, arm-soc
On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote:
> > The i.MX8M Mini has supports the MICFIL digital interface.
> > It's a 16-bit audio signal from a PDM microphone bitstream.
> > The driver is already in the kernel, but the node is missing.
> >
> > This patch adds the micfil node.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > index c63685ae80ee..d46e727fc362 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > @@ -339,6 +339,25 @@ sai6: sai@30060000 {
> > status = "disabled";
> > };
> >
> > + micfil: micfil@30080000 {
>
> Find a generic node name, audio-controller maybe?
The SAI's nodes are called SAI@xxxx
If that's a deal-breaker, I can push a V3.
I didn't see anyone from the device tree side comment, and the device
tree binding doc states 'micfil@xxxxxx' so I used what was documented
in the fsl,micfil.txt
adam
>
> Shawn
>
> > + compatible = "fsl,imx8mm-micfil";
> > + reg = <0x30080000 0x10000>;
> > + interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clk IMX8MM_CLK_PDM_IPG>,
> > + <&clk IMX8MM_CLK_PDM_ROOT>,
> > + <&clk IMX8MM_AUDIO_PLL1_OUT>,
> > + <&clk IMX8MM_AUDIO_PLL2_OUT>,
> > + <&clk IMX8MM_CLK_EXT3>;
> > + clock-names = "ipg_clk", "ipg_clk_app",
> > + "pll8k", "pll11k", "clkext3";
> > + dmas = <&sdma2 24 25 0x80000000>;
> > + dma-names = "rx";
> > + status = "disabled";
> > + };
> > +
> > gpio1: gpio@30200000 {
> > compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio";
> > reg = <0x30200000 0x10000>;
> > --
> > 2.25.1
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: imx8mm: Add support for micfil
2020-10-28 12:10 ` Adam Ford
@ 2020-10-29 19:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-10-29 19:24 UTC (permalink / raw)
To: Adam Ford
Cc: devicetree, Will Deacon, Fabio Estevam, Sascha Hauer, aford,
Linux Kernel Mailing List, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Catalin Marinas, Shawn Guo, arm-soc
On Wed, Oct 28, 2020 at 07:10:37AM -0500, Adam Ford wrote:
> On Tue, May 19, 2020 at 8:03 PM Shawn Guo <shawnguo@kernel.org> wrote:
> >
> > On Sat, May 02, 2020 at 07:59:48AM -0500, Adam Ford wrote:
> > > The i.MX8M Mini has supports the MICFIL digital interface.
> > > It's a 16-bit audio signal from a PDM microphone bitstream.
> > > The driver is already in the kernel, but the node is missing.
> > >
> > > This patch adds the micfil node.
> > >
> > > Signed-off-by: Adam Ford <aford173@gmail.com>
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > index c63685ae80ee..d46e727fc362 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> > > @@ -339,6 +339,25 @@ sai6: sai@30060000 {
> > > status = "disabled";
> > > };
> > >
> > > + micfil: micfil@30080000 {
> >
> > Find a generic node name, audio-controller maybe?
>
> The SAI's nodes are called SAI@xxxx
>
> If that's a deal-breaker, I can push a V3.
>
> I didn't see anyone from the device tree side comment, and the device
> tree binding doc states 'micfil@xxxxxx' so I used what was documented
> in the fsl,micfil.txt
Hi,
The example in the binding is not a binding itself. It can be misleading
or even incorrect and it is not a reason to use such in DTS.
Could be also audio-codec but it is not accurate (as it is only from the
microphone to digital).
Shawn's proposal is the best, I think.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-10-29 19:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-02 12:59 [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Adam Ford
2020-05-02 12:59 ` [PATCH] arm64: dts: imx8mm: Add support for micfil Adam Ford
2020-05-20 1:03 ` Shawn Guo
2020-10-28 12:10 ` Adam Ford
2020-10-29 19:24 ` Krzysztof Kozlowski
2020-05-20 1:02 ` [PATCH] arm64: defconfig: Enable some audio drivers on i.MX8M Mini Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).