From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F77C433DF for ; Wed, 20 May 2020 01:06:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAC5120708 for ; Wed, 20 May 2020 01:06:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oFh1s5yi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="alcv5suy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAC5120708 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D/DOgcrE7geabDJSMl0Pe6l+LWNTmmkyU8G0iJwFmGY=; b=oFh1s5yiFUJ9xa +qJYpsvAwiuK+2bO/Tc02UfXPdnUhxKEbjf40+uvSS6OqPBqLg4/r97mGFbCZbQmvOF8Lp3QfdIzR WyJha3YynpJ4KiXegtSQ9GaSbUrp4+pF1/wZSuka3DTxgv+3SU0o6VZIAP7P1JjpvfcrFYgtjkeIc JGgFrzEiQOZHA6nydn6VIx5USQ/RsTFFDT0CoOqSKAAmW/Bu4b1XEcshZDYUETs+dcNfTCcIb2Ryl /t542dadPjaJKP0Fuyfu6Jqiu4jhZYk7HVzWQwEFWYKCSHWBIkn+DhqvF6hViRLF5QILNOJCJl6mz YLUG2hBKLwh786dxLUpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbDBR-0008Ey-AL; Wed, 20 May 2020 01:06:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbDBM-0008Dr-Qo for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 01:06:06 +0000 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE4A620708; Wed, 20 May 2020 01:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589936764; bh=zor48bXJQ4c2kAxaJluW7+9Ew89ICgOqiSGEW4LgzI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=alcv5suyhyRxqBPQAM026Gtjv1cHG5anqpF86KMAtYP0hwh+PBQlJF/PVGXhNv4py BdZ2zF9jIdu1TFQSXWQHstetWrldKlrOCS89qy6W4QoeRvKVUGZi21LE4NNxm3hWte jSQa+8bLDq2vusmQL0Q7BQVLd8MkMS+Qp6fNoi9g= Date: Wed, 20 May 2020 09:05:59 +0800 From: Shawn Guo To: Adam Ford Subject: Re: [PATCH] arm64: dts: imx8mm: Add node for SPDIF Message-ID: <20200520010558.GF11739@dragon> References: <20200502132011.196045-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200502132011.196045-1-aford173@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200519_180604_930770_4B009DF2 X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Sascha Hauer , aford@beaconembedded.com, linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 02, 2020 at 08:20:11AM -0500, Adam Ford wrote: > The i.MX8M Mini can support SPIDF which is very similar to the > IP used on the i.MX35. > > This patch adds the SPIF node. > > Signed-off-by: Adam Ford > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index d46e727fc362..00aad55ece65 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -358,6 +358,29 @@ micfil: micfil@30080000 { > status = "disabled"; > }; > > + spdif1: spdif@30090000 { It should be in a patch series with previous micfil one, as it cannot be applied independently. > + compatible = "fsl,imx8mm-spdif", "fsl,imx35-spdif"; > + reg = <0x30090000 0x10000>; > + interrupts = ; > + clocks = <&clk IMX8MM_CLK_AUDIO_AHB>, /* core */ > + <&clk IMX8MM_CLK_24M>, /* rxtx0 */ > + <&clk IMX8MM_CLK_SPDIF1>, /* rxtx1 */ > + <&clk IMX8MM_CLK_DUMMY>, /* rxtx2 */ > + <&clk IMX8MM_CLK_DUMMY>, /* rxtx3 */ > + <&clk IMX8MM_CLK_DUMMY>, /* rxtx4 */ > + <&clk IMX8MM_CLK_AUDIO_AHB>, /* rxtx5 */ > + <&clk IMX8MM_CLK_DUMMY>, /* rxtx6 */ > + <&clk IMX8MM_CLK_DUMMY>, /* rxtx7 */ > + <&clk IMX8MM_CLK_DUMMY>; /* spba */ > + clock-names = "core", "rxtx0", > + "rxtx1", "rxtx2", > + "rxtx3", "rxtx4", > + "rxtx5", "rxtx6", > + "rxtx7", "spba"; > + dmas = <&sdma2 28 18 0>, <&sdma2 29 18 0>; > + dma-names = "rx", "tx"; > + status = "disabled"; > + }; Have a newline between nodes. Shawn > gpio1: gpio@30200000 { > compatible = "fsl,imx8mm-gpio", "fsl,imx35-gpio"; > reg = <0x30200000 0x10000>; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel