From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C753C433E0 for ; Wed, 20 May 2020 07:51:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E6274207FB for ; Wed, 20 May 2020 07:51:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LBMkR1BH"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="czMZPTd0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E6274207FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yr7vDG+YWuO22Ar5RJzhn8per4mUD4lBYagb2BIYR1c=; b=LBMkR1BHQdhIcX VVN4PW1ZrG/VNRJ8N/2Gb10QsYdZeqFJpolkDJlrekr8cJ830sHWM6pOTF5RMPp+7B7yNodQDI/Wx AkLFHrdk2A1nmsnrxo8kiiVph5zteGfaD7yFbBOLZEP/JYHia4ZqWxaYpOq3IxinNsVTeOpP6PQiC Pa9UR9xWYeRwHjOhURqi8NWZXubg7lafrv60tujsPLKGY6c7NpY9eHCx78xIMPdKYiKucdaHHJvIb skftkXQH2XvJ0mDu2INUhUU+KVj8+TWIiT70832j5TP2iTrK9XDPhhVLBdMZ8+bsSadBETheTVF0m rcKPVgvOF8afR6ATv3Kw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbJW0-0008Qa-TC; Wed, 20 May 2020 07:51:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbJVx-0008QB-ET for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 07:51:46 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 17377207ED; Wed, 20 May 2020 07:51:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589961105; bh=dQ/uADpcOq2BLNT5fjKHvtag8jw9uAoK2Wq6CuJkc1I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=czMZPTd0ovp4NsCjgdIqD+35Cg68zSygTaXHzQqEd3j4kGr6Pi+hskDGbHafHQSWR ogv72iz2IkTgbJJevFFf5C03lYg3pNn/ZDp5wdulrg9p8XAYsEM4ifODgUIhdXEw3N Q767EJ5GyAOFf2BlbVzvi8TZ1nd0YSJQgyCaDJlE= Date: Wed, 20 May 2020 08:51:40 +0100 From: Will Deacon To: Joakim Zhang Subject: Re: [PATCH 2/2] perf/imx_ddr: Add stop counter support for i.MX8MP Message-ID: <20200520075140.GB23818@willie-the-truck> References: <20200225125644.18853-1-qiangqing.zhang@nxp.com> <20200225125644.18853-2-qiangqing.zhang@nxp.com> <20200302112441.GB7995@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_005145_505792_A59CE148 X-CRM114-Status: GOOD ( 11.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "robin.murphy@arm.com" , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 16, 2020 at 09:51:13AM +0000, Joakim Zhang wrote: > Any comments about this issue? Thanks a lot! You didn't really answer any of my questions, so I don't really know what to do with this. - The locking appears to be broken. Your solution was to remove it entirely. - It appears to be a user visible change and you haven't explained how it continues to work with old userspace - Perf core is not aware of you stopping counters and you haven't said why that's not an issue. While these issues are outstanding, I cannot merge the patch. Sorry. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel