From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75510C433E0 for ; Wed, 20 May 2020 12:25:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 481D520756 for ; Wed, 20 May 2020 12:25:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fEb2JL7U"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Py3Hwqks" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 481D520756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tnJySzDdfIcIYVehsTGkI5Kfy+JrWDvzA2IMfaqXO1A=; b=fEb2JL7UQHwE2a nwIm7BR9GnyU76Nhh3NdlbSKN50Y2CITkuqi9b4qAXtFw8QloyaM6zdJUudCzvYXpcgCxbRn41Ryl ScjDiijKF/FO10HccRlU3AmtCgtOVk0upFiBj41mGZItiBhEP2S4kFBVRmd/36b2MiATeaSetYoDq wz93bKFqSx5ntX2PoMTajrqGTnH7G4GsSgcLWxIFIGRpRXCTBlxSkHPRM9oIMc/LpJH9Gx6fPMCH5 RXnQ6vuUOLV/Nry4J/yEr8ltte0IibdMjJSmb1wvbVuKP5sLUB2DdH98xXtEhqGO/EGFL8RbZle2J MDQt6Qm8Y+RiUevwpphw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbNmQ-0000Z4-9U; Wed, 20 May 2020 12:25:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jbNmM-0000YZ-Ad for linux-arm-kernel@lists.infradead.org; Wed, 20 May 2020 12:24:59 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BEAEE20756; Wed, 20 May 2020 12:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589977497; bh=d/z8UA8FFrA6+I5LNQQLsUptQcBDDl+RwCUFWJSU6zw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Py3HwqksfPjk89NWRpPwnn8sfAtd0DzcrCytjVZ992kud/N7uojsiaPz/FQw8pqcg P7IcO5Q9CA3iDgpHjnjb9EqpJexvxJi3/5cF0SCESbE0/f9a4x/W7MUV4j3pLoxD1j YvmuYFDD5uJWdtsGKRoueuBp35Dh0IdzQ19NPaH8= Date: Wed, 20 May 2020 13:24:53 +0100 From: Will Deacon To: Jean-Philippe Brucker Subject: Re: [PATCH] perf/smmuv3: Allow sharing MMIO registers with the SMMU driver Message-ID: <20200520122453.GB25815@willie-the-truck> References: <20200421155745.19815-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200421155745.19815-1-jean-philippe@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200520_052458_385168_AF55F04D X-CRM114-Status: GOOD ( 14.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, iommu@lists.linux-foundation.org, lorenzo.pieralisi@arm.com, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 21, 2020 at 05:57:46PM +0200, Jean-Philippe Brucker wrote: > Some Arm SMMUv3 implementations, for example Arm CoreLink MMU-600, embed > the PMCG registers into the SMMU MMIO regions. It currently causes probe > failure because the PMU and SMMU drivers request overlapping resources. > > Avoid the conflict by calling devm_ioremap() directly from the PMU > driver. We loose some sanity-checking of the memory map provided by > firmware, which doesn't seem catastrophic. > > Signed-off-by: Jean-Philippe Brucker > --- > > So this is the simplest solution, and I don't think we're missing much > by skipping the resource reservation. I've also been exploring a more > complex approach [1] which has the SMMU driver perform resource > reservation on behalf of the PMU driver, but I'm not sure it's > necessary. > > Please test, I've only tried the RevC FastModel using devicetree so far. > > [1] https://jpbrucker.net/git/linux/log/?h=smmu/pmu > --- > drivers/perf/arm_smmuv3_pmu.c | 28 +++++++++++++++++++++------- > 1 file changed, 21 insertions(+), 7 deletions(-) Is this patch still needed? I can't quite follow from the discussion. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel