From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDE14C433DF for ; Fri, 22 May 2020 12:33:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 967EF206B6 for ; Fri, 22 May 2020 12:33:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P1hV6hBG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 967EF206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j/ao9eGmMI2tov09WjGGQWlcBAyXlxVi4kEo7d1bq60=; b=P1hV6hBG87hdVt /jR1p6FbJWp83bk/6ztUBXCsPd+W0oDIzTXv4xrkb/2PRamOppuk8JecQLWFg/qCj4ktFZr1xI8xk KzvrZE1gTbvx2SohSuFwWwD73ZP2P7qT1LozqwpZokSQPtVcbH32WtDyn9JbzXcGV586D92Prg1PF FmHxhGnuasgQAaMvCBI+YWD4cYkVR4cg7NOqLUV1LHV5+0IK+XJ3eYmEiqER47+r3Uba9UZI2AY50 E8ef8AOoemU1faHSzUSQw6EzY1eH/K5O7vWGltFzmq3Xc/vdobJhS1WQC4iLCVNIFMIPA4MmwYaHx lBPeYfH9iV7dvP0pKBKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc6r6-0001KB-DR; Fri, 22 May 2020 12:32:52 +0000 Received: from mga04.intel.com ([192.55.52.120]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jc6r3-0001Jh-LD for linux-arm-kernel@lists.infradead.org; Fri, 22 May 2020 12:32:50 +0000 IronPort-SDR: xmM0PVvxiehbcCElUOlEayaglZQS3JM6gvXKeEGyumWNMNS+IlhhflpPz59ge/rJBcyDxaDmzC s3JMRAQWNDNA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2020 05:32:49 -0700 IronPort-SDR: gdNOhWPiD26Qwsk/8U/6trhMNaOkd6iMPsw+64KEMYwuMKrff1ja/OqQ3CbSLJRswf4BsofcDC tkglDYyxrfwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,421,1583222400"; d="scan'208";a="309358979" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by FMSMGA003.fm.intel.com with ESMTP; 22 May 2020 05:32:46 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jc6r2-008EIs-Rz; Fri, 22 May 2020 15:32:48 +0300 Date: Fri, 22 May 2020 15:32:48 +0300 From: Andy Shevchenko To: Tali Perry Subject: Re: [PATCH v13 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton Message-ID: <20200522123248.GC1634618@smile.fi.intel.com> References: <20200522113312.181413-1-tali.perry1@gmail.com> <20200522113312.181413-4-tali.perry1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200522113312.181413-4-tali.perry1@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200522_053249_708526_F216A5E3 X-CRM114-Status: UNSURE ( 8.20 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, tmaimon77@gmail.com, yuenn@google.com, avifishman70@gmail.com, venture@google.com, openbmc@lists.ozlabs.org, wsa@the-dreams.de, brendanhiggins@google.com, ofery@google.com, linux-kernel@vger.kernel.org, kfting@nuvoton.com, robh+dt@kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, benjaminfair@google.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 22, 2020 at 02:33:12PM +0300, Tali Perry wrote: > Add support for slave mode for Nuvoton > NPCM BMC I2C controller driver. I guess it will require v14, so, few nits below. ... > +const int npcm_i2caddr[I2C_NUM_OWN_ADDR] = { > + NPCM_I2CADDR1, NPCM_I2CADDR2, > + NPCM_I2CADDR3, NPCM_I2CADDR4, > + NPCM_I2CADDR5, NPCM_I2CADDR6, > + NPCM_I2CADDR7, NPCM_I2CADDR8, > + NPCM_I2CADDR9, NPCM_I2CADDR10, One TAB is enough. > + }; No need to indent at all. ... > + /* Set and enable the address */ > + iowrite8(sa_reg, bus->reg + npcm_i2caddr[(int)addr_type]); I'm wondering why you need a casting here. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel