From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99EECC433E0 for ; Sun, 24 May 2020 01:42:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7160520823 for ; Sun, 24 May 2020 01:42:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lbKrEC+g"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GtZPJ7jM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7160520823 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tAwkzSGjukCXZG/T81q1YSpYkMzFjU5XPu/KD4h/+UE=; b=lbKrEC+gCxIJ5L brC6OFtqUcLISdGy04tTQAdcpAUffmEFVEOMTP9B5IIhje2gRgaEtYvemFzA3peL5hNoM9pwGwuLw HRfethM2pGWCMnXQ/uJ0KGP0aH8ND4zmwwBqJeYq4RCeSGaT0q7BwSoeWJT1xJ2TaWNo6NT91/yRp Vg7ZkNifJ5am57kOYY1q1R1D5/wNfgOQ22NCjztfdHZMnWKFxV1V4kkJNFTIw7FlhwwR/HPhcbsOp g4ExCY1Kei3zJXEZ1NaiLxUZDXF6ZkI6+tODybvX/MbiCdf4gtvI1c4VM1dGalE9eilVhLSPdaGEc lO8vIH7SshWi3XL4ZWoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcfen-0003wl-6d; Sun, 24 May 2020 01:42:29 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jcfek-0003wN-9v for linux-arm-kernel@lists.infradead.org; Sun, 24 May 2020 01:42:27 +0000 Received: by mail-pf1-x441.google.com with SMTP id x13so7030566pfn.11 for ; Sat, 23 May 2020 18:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WOxnSmEbJ8sld8voIH7dFeotuFTK+vKmyxU3MIIUb6w=; b=GtZPJ7jMgTd975u9HvJI8Vb4cQ0PF/kILo5F96YhAHphc7CWosNo5glezVlXxhXmfe 2gU8cK7Y8pxzBSBxL2vGV0mECSCAAp8pkJw0+o85UREcMBs5pU34VmV2PquiuIlMBZVS I6mX64GzgFs+eJMW1wOvV1EV776L2G42DYYbsYCNlRri+pFm1GFU598QW95NFZbyWUIv mkxS+NW/iDwbC1BzK0EnISSbg2E5G/UhDnndhRbKFe1rh3EbsWJYpuQ85dqvt96abTs7 h0rIdsreV3awAzUw83FAk+0u4QFJaMqks/RfYUAH6W3qqEF3vq6g7HD6yqmDacd3ngUG boqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WOxnSmEbJ8sld8voIH7dFeotuFTK+vKmyxU3MIIUb6w=; b=WrfmwM9o7nmxtXr5orH2ABHMOvsoWEy7CYRwyaRHRmuuBcHnd9X1wIfjnf3kk+0QiC B0HlxCQlUN7mq+BU1VmfFkfS6q+9OuT1qrydfLVxcFya4uOzebcqa11HGZOMVTvh+72i o4k/3RyhbgEg18DjpiN6y/cX/r7qpM0JYn43jjSgEGmE8zuLYscalEVRJeEGML3W2Gsy NH2VHlEYYvzaF8HGenjFoKu97DF2aa2deM8Tc7yYYt9wWHyS8dUihafBrlw+xW95k86S Mm9s2Iyn2Wiq5BMesWF4wop88iuzD4qdNzxmlKxjnuN6bZei6dEOJDaNvbPpIiku+Dss F40A== X-Gm-Message-State: AOAM532Jdoo/413PJILmgfgdXtXJJ3TVYm01vDOMqo++pa2v0sBXDWVj noIUvufbhdCExdn9Rh0IyKE= X-Google-Smtp-Source: ABdhPJz/r2ARO1+zFfzMU6tmLJif4eacW94VQyHfz5ZBMq8FJBOIwE90YKcA4DCDXFxeOk1t1yVKbQ== X-Received: by 2002:a62:c5c2:: with SMTP id j185mr3837671pfg.74.1590284544972; Sat, 23 May 2020 18:42:24 -0700 (PDT) Received: from localhost (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id y18sm9957798pfr.100.2020.05.23.18.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2020 18:42:24 -0700 (PDT) Date: Sat, 23 May 2020 18:42:20 -0700 From: Richard Cochran To: Jianyong Wu Subject: Re: [RFC PATCH v12 09/11] ptp: extend input argument for getcrosstimestamp API Message-ID: <20200524014220.GA335@localhost> References: <20200522083724.38182-1-jianyong.wu@arm.com> <20200522083724.38182-10-jianyong.wu@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200522083724.38182-10-jianyong.wu@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200523_184226_370689_4232AAA8 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark.Rutland@arm.com, maz@kernel.org, justin.he@arm.com, Wei.Chen@arm.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, netdev@vger.kernel.org, Steve.Capper@arm.com, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, steven.price@arm.com, Kaly.Xin@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 22, 2020 at 04:37:22PM +0800, Jianyong Wu wrote: > sometimes we may need tell getcrosstimestamp call back how to perform > itself. Extending input arguments for getcrosstimestamp API to offer more > exquisite control for the operation. This text does not offer any justification for the change in API. > diff --git a/include/linux/ptp_clock_kernel.h b/include/linux/ptp_clock_kernel.h > index c602670bbffb..ba765647e54b 100644 > --- a/include/linux/ptp_clock_kernel.h > +++ b/include/linux/ptp_clock_kernel.h > @@ -133,7 +133,8 @@ struct ptp_clock_info { > int (*gettimex64)(struct ptp_clock_info *ptp, struct timespec64 *ts, > struct ptp_system_timestamp *sts); > int (*getcrosststamp)(struct ptp_clock_info *ptp, > - struct system_device_crosststamp *cts); > + struct system_device_crosststamp *cts, > + long *flag); Well, you ignored the kernel doc completely. But in any case, I must NAK this completely opaque and mysterious change. You want to add a random pointer to some flag? I don't think so. Thanks, Richard _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel