From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BCFC433E0 for ; Mon, 25 May 2020 09:07:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3655F20823 for ; Mon, 25 May 2020 09:07:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JSc1uBHa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3655F20823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=dERVMZ2lGP6xeeP9q/JeWs9lKlVD0W1akeYkETasRrs=; b=JSc1uBHaXv7DpdEzBfjoT2yj+ xOTkJECpl4Wg4RPA+2DXf1Xw31Taml5xzBtSiSyPJHLXNReiMHFC3U2q7sj9jb9OHK7hxfUVRn1XG uPKoMMccK7moTdXR35HIzQqzW3p6/Sw3xHKUPCdGKevYZNQIxTnh+fm3WClugVweqfKc86T3LIbFf 1sImt9yE5/+DpvtOa1OFTeKNB+bJ5jXRo3jMYHewsvIGaQs+igoQekQ4xAndD+ywgEdOsHhx7EUjl bj2WgSIZjWtjDL1w+q3bUrxs4sLkNp++3msj1RRcvllWbSNZmHBoeOnFCR1CR3P5iY0qANOxWMBhI 4ZE+TWs9w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd94w-0007Sr-6x; Mon, 25 May 2020 09:07:26 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jd94r-0007Qn-Ul; Mon, 25 May 2020 09:07:23 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 925E81C02B1; Mon, 25 May 2020 11:07:19 +0200 (CEST) Date: Mon, 25 May 2020 11:07:18 +0200 From: Pavel Machek To: Florian Fainelli Subject: Re: [PATCH v3 1/8] dt-bindings: net: meson-dwmac: Add the amlogic,rx-delay-ns property Message-ID: <20200525090718.GB16796@amd> References: <20200512211103.530674-1-martin.blumenstingl@googlemail.com> <20200512211103.530674-2-martin.blumenstingl@googlemail.com> <20200524212843.GF1192@bug> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_020722_137806_D2D60F5E X-CRM114-Status: GOOD ( 17.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andrew@lunn.ch, jianxin.pan@amlogic.com, devicetree@vger.kernel.org, Martin Blumenstingl , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, linux-amlogic@lists.infradead.org, davem@davemloft.net, linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============2678899905328651259==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2678899905328651259== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OwLcNYc0lM97+oe1" Content-Disposition: inline --OwLcNYc0lM97+oe1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > On Tue 2020-05-12 23:10:56, Martin Blumenstingl wrote: > >> The PRG_ETHERNET registers on Meson8b and newer SoCs can add an RX > >> delay. Add a property with the known supported values so it can be > >> configured according to the board layout. > >> > >> Reviewed-by: Andrew Lunn > >> Signed-off-by: Martin Blumenstingl > >> --- > >> .../bindings/net/amlogic,meson-dwmac.yaml | 13 +++++++++++++ > >> 1 file changed, 13 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac= =2Eyaml b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > >> index ae91aa9d8616..66074314e57a 100644 > >> --- a/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > >> +++ b/Documentation/devicetree/bindings/net/amlogic,meson-dwmac.yaml > >> @@ -67,6 +67,19 @@ allOf: > >> PHY and MAC are adding a delay). > >> Any configuration is ignored when the phy-mode is set to = "rmii". > >> =20 > >> + amlogic,rx-delay-ns: > >> + enum: > >=20 > > Is it likely other MACs will need rx-delay property, too? Should we get= rid of the amlogic, > > prefix? >=20 > Yes, there are several MAC bindings that already define a delay property: >=20 > Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml: > allwinner,rx-delay-ps: > Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml: > allwinner,rx-delay-ps: > Documentation/devicetree/bindings/net/apm-xgene-enet.txt:- rx-delay: > Delay value for RGMII bridge RX clock. > Documentation/devicetree/bindings/net/apm-xgene-enet.txt: rx-delay > =3D <2>; > Documentation/devicetree/bindings/net/cavium-pip.txt:- rx-delay: Delay > value for RGMII receive clock. Optional. Disabled if 0. > Documentation/devicetree/bindings/net/mediatek-dwmac.txt:- > mediatek,rx-delay-ps: RX clock delay macro value. Default is 0. > Documentation/devicetree/bindings/net/mediatek-dwmac.txt: > mediatek,rx-delay-ps =3D <1530>; >=20 > standardizing on rx-delay-ps and tx-delay-ps would make sense since that > is the lowest resolution and the property would be correctly named with > an unit in the name. Seems like similar patch is already being reviewed from Dan Murphy (?) =66rom TI. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --OwLcNYc0lM97+oe1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl7LisYACgkQMOfwapXb+vJCzACfcW9RZlns94NhbAXsafn1CBvX orcAoL3pNyoH5KhUL0FoV+EGTKQVEBDM =yjue -----END PGP SIGNATURE----- --OwLcNYc0lM97+oe1-- --===============2678899905328651259== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2678899905328651259==--