From: David Miller <davem@davemloft.net>
To: fugang.duan@nxp.com
Cc: p.zabel@pengutronix.de, alexandre.torgue@st.com,
netdev@vger.kernel.org, joabreu@synopsys.com,
mcoquelin.stm32@gmail.com, kuba@kernel.org,
peppe.cavallaro@st.com, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net 1/1] net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a
Date: Tue, 26 May 2020 16:28:25 -0700 (PDT) [thread overview]
Message-ID: <20200526.162825.1972012781165820310.davem@davemloft.net> (raw)
In-Reply-To: <1590394694-5505-1-git-send-email-fugang.duan@nxp.com>
From: Fugang Duan <fugang.duan@nxp.com>
Date: Mon, 25 May 2020 16:18:14 +0800
> For rx filter 'HWTSTAMP_FILTER_PTP_V2_EVENT', it should be
> PTP v2/802.AS1, any layer, any kind of event packet, but HW only
> take timestamp snapshot for below PTP message: sync, Pdelay_req,
> Pdelay_resp.
>
> Then it causes below issue when test E2E case:
> ptp4l[2479.534]: port 1: received DELAY_REQ without timestamp
> ptp4l[2481.423]: port 1: received DELAY_REQ without timestamp
> ptp4l[2481.758]: port 1: received DELAY_REQ without timestamp
> ptp4l[2483.524]: port 1: received DELAY_REQ without timestamp
> ptp4l[2484.233]: port 1: received DELAY_REQ without timestamp
> ptp4l[2485.750]: port 1: received DELAY_REQ without timestamp
> ptp4l[2486.888]: port 1: received DELAY_REQ without timestamp
> ptp4l[2487.265]: port 1: received DELAY_REQ without timestamp
> ptp4l[2487.316]: port 1: received DELAY_REQ without timestamp
>
> Timestamp snapshot dependency on register bits in received path:
> SNAPTYPSEL TSMSTRENA TSEVNTENA PTP_Messages
> 01 x 0 SYNC, Follow_Up, Delay_Req,
> Delay_Resp, Pdelay_Req, Pdelay_Resp,
> Pdelay_Resp_Follow_Up
> 01 0 1 SYNC, Pdelay_Req, Pdelay_Resp
>
> For dwmac v5.10a, enabling all events by setting register
> DWC_EQOS_TIME_STAMPING[SNAPTYPSEL] to 2’b01, clearing bit [TSEVNTENA]
> to 0’b0, which can support all required events.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Applied and queued up for -stable, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-26 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 8:18 [PATCH net 1/1] net: stmmac: enable timestamp snapshot for required PTP packets in dwmac v5.10a Fugang Duan
2020-05-26 23:28 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-25 8:09 Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526.162825.1972012781165820310.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexandre.torgue@st.com \
--cc=fugang.duan@nxp.com \
--cc=joabreu@synopsys.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox