From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52096C433DF for ; Tue, 26 May 2020 14:38:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18B622078C for ; Tue, 26 May 2020 14:38:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="MSShHpbg"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="WDpkxa1j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18B622078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qYPYqGUqlGo7Uq7yvHoLNFdX+jySoKniBjwK8c4DrUs=; b=MSShHpbgzzaT5r zc8oYeC1j/Bdb1kRrBo9x8Jfv8r0MspnUz/8VEdV99k073Cc6STIHgJW+mPa1YSSBiwrUr1bx7b0Q oN84qmmeTTpvjCOg8/dyxjszEk6NHTtR7OPCT25TAiEJDGQzh+/fhuwReQUmpRTfFKCivCaa2LuYd iLT9WlbLdSlneBWnGaNat5waClTJAGgtCpENId8QIBnC762waH0WK0NqqCCY23wXTZYUGvg6203NT 030ZC6DAr7UFtKL6NnuDnmDW/ZjwrAzYsGb4tQcY+R42eqBEsjR5wIfIXN1Q0MlJQ7xTYwpPcInln RPGR97AN/RZXJX17kwFw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdaiS-0007bk-6O; Tue, 26 May 2020 14:38:04 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdaiP-0007b6-KE for linux-arm-kernel@lists.infradead.org; Tue, 26 May 2020 14:38:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=6r4j8rBbTE2dFZlMnxrudaMntRuorYxjw3EurSlJSOc=; b=WDpkxa1jYDyPvIN+x4b9XNo1b ROgGmfb4JRqdVtHcI57bGMhgBcYQ8HC3NX/GYKatTT4DMGuSwhhNVyRDwDWjmRodfSuaLbdb4SGYx SvozEC1iXVZXDy8/X8giPsSn8P7f1FhgETk5zKolqyN33eOS09+BqvjusAMG/3q87QUES8d1ku4Ol h60FSFqwCLvwXOCywz3TeR7HvQudM8sAxwPsCqdGGyBzALNw4XCEjlTTzIgA/BaUZa7b5AxEPHbBv Rhoel2jiEjL6FmfZdPfF+u0e3YqImG8qIFDU6jiDOKtFR13ZqByw7yG1A89CA4okEhYfpxTQAbqhb PQLv/Zc5Q==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:45316) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdaiL-00081w-0V; Tue, 26 May 2020 15:37:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jdaiK-0005Rw-GH; Tue, 26 May 2020 15:37:56 +0100 Date: Tue, 26 May 2020 15:37:56 +0100 From: Russell King - ARM Linux admin To: Linus Walleij Subject: Re: [PATCH] ARM: mm: Simplify act_mm macro Message-ID: <20200526143756.GZ1551@shell.armlinux.org.uk> References: <20200526143249.68202-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200526143249.68202-1-linus.walleij@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_073801_665988_52EADD2C X-CRM114-Status: GOOD ( 14.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 26, 2020 at 04:32:49PM +0200, Linus Walleij wrote: > The act_mm assembly macro is actually partly reimplementing > get_thread_info so let's just use that. > > Suggested-by: Russell King > Signed-off-by: Linus Walleij > --- > arch/arm/mm/proc-macros.S | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/arm/mm/proc-macros.S b/arch/arm/mm/proc-macros.S > index 60ac7c5999a9..65eaea85d3d6 100644 > --- a/arch/arm/mm/proc-macros.S > +++ b/arch/arm/mm/proc-macros.S > @@ -5,7 +5,6 @@ > * VMA_VM_FLAGS > * VM_EXEC > */ > -#include > #include > #include > > @@ -31,9 +30,7 @@ > * act_mm - get current->active_mm > */ > .macro act_mm, rd > - bic \rd, sp, #(THREAD_SIZE - 1) & ~63 > - bic \rd, \rd, #63 > - ldr \rd, [\rd, #TI_TASK] > + get_thread_info \rd This is not quite the same thing. get_thread_info loads into \rd the address of the thread_info structure. That's what the two bic instructions are doing. The LDR is then loading the address of the task_struct into \rd. > .if (TSK_ACTIVE_MM > IMM12_MASK) > add \rd, \rd, #TSK_ACTIVE_MM & ~IMM12_MASK > .endif So this change alters which structure \rd is pointing to. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel