From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C44A2C433E0 for ; Tue, 26 May 2020 15:01:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E71F206D5 for ; Tue, 26 May 2020 15:01:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EGbMnETc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E71F206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B+8+fiRedzW1xC5olBDCiYuf9I+cz6WdifW0OqrTC+4=; b=EGbMnETcrnQ5/4 QS3RT8Sc21a03ptmcleIefLYS2dudM36Xdkn6Qoa1e6LCF4jtjXxoEaCdeavIL1fTuMXpk4lUnpTG 79wOu8Hlv/WOrkr0vPf97VBv6M58gG/IkzUDjBmyN0HsImNif1zHz89MTWTFEA50gm1yDOyKel8ME dBZ/BQJGMmOH2afMMe3iKEagu1+vIJaqTDGm47GKw4tl8H4V5BS4tHp8jqVMZYKLRjJeqq5kNZOMh EEWtD5bYaqxAdKByNIP6bzI2z6G3h9Ww5NPPHR7C3g2tH4Le8Ig/SBt74aac4pHJhuAT2a0EI3Ccw VsQHy2PL+FIanCzY99Zw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdb5O-0007vF-1G; Tue, 26 May 2020 15:01:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdb5H-0007uK-F8 for linux-arm-kernel@lists.infradead.org; Tue, 26 May 2020 15:01:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C8C8A30E; Tue, 26 May 2020 08:01:38 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B893B3F52E; Tue, 26 May 2020 08:01:37 -0700 (PDT) Date: Tue, 26 May 2020 16:01:35 +0100 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH V2] arm64/cpufeature: Add get_arm64_ftr_reg_nowarn() Message-ID: <20200526150135.GI17051@gaia> References: <1590500353-28082-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1590500353-28082-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_080139_550563_98C3F6C5 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Suzuki K Poulose , linux-kernel@vger.kernel.org, Mark Brown , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 26, 2020 at 07:09:13PM +0530, Anshuman Khandual wrote: > @@ -632,8 +654,6 @@ static void __init init_cpu_ftr_reg(u32 sys_reg, u64 new) > const struct arm64_ftr_bits *ftrp; > struct arm64_ftr_reg *reg = get_arm64_ftr_reg(sys_reg); > > - BUG_ON(!reg); > - > for (ftrp = reg->ftr_bits; ftrp->width; ftrp++) { > u64 ftr_mask = arm64_ftr_mask(ftrp); > s64 ftr_new = arm64_ftr_value(ftrp, new); > @@ -762,7 +782,6 @@ static int check_update_ftr_reg(u32 sys_id, int cpu, u64 val, u64 boot) > { > struct arm64_ftr_reg *regp = get_arm64_ftr_reg(sys_id); > > - BUG_ON(!regp); > update_cpu_ftr_reg(regp, val); > if ((boot & regp->strict_mask) == (val & regp->strict_mask)) > return 0; > @@ -776,9 +795,6 @@ static void relax_cpu_ftr_reg(u32 sys_id, int field) > const struct arm64_ftr_bits *ftrp; > struct arm64_ftr_reg *regp = get_arm64_ftr_reg(sys_id); > > - if (WARN_ON(!regp)) > - return; I think Will wanted an early return in all these functions not just removing the BUG_ON(). I'll let him clarify. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel