From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 731FCC433E0 for ; Tue, 26 May 2020 18:08:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49EF92065F for ; Tue, 26 May 2020 18:08:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ulvp/MJw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49EF92065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TjaIfhcDtP4mE2FFSJ4Xi8bY4Xnomh2LEQe9wXL7I+0=; b=ulvp/MJw9Fl1UV DCa8F4P9keRO2TQoMJ8KYTgJ5HwcbZhBzntfYdFr3XtvPYpeclgfWezYFHQwbADUo00jBOJZGSoUh rXhkaJKylfVEt4zLtD+YO/8PbVxjHIwJbbbnek+pTUIodGagsOf+cOcReKI3QFeKPqpOiJKbNTKjX CfFk/SdEbHJOrnZcG/gZG4ltn0Kc8HgKLdd71V4A4tLMg0OyICeoMOne+90A7tBDgfiJM/JsoeJcZ 2+yAVlG1vn79bYwtHYnW16abbWo8p7KiNAaLD/jVFM5Xk4l1hdNNtxjVbJGev4eSMWu2439kbdlD2 9O65/Yx6fF0Cv8I0WjoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jde0R-00055N-Fm; Tue, 26 May 2020 18:08:51 +0000 Received: from mail-io1-f67.google.com ([209.85.166.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jde0M-0004zl-U0 for linux-arm-kernel@lists.infradead.org; Tue, 26 May 2020 18:08:48 +0000 Received: by mail-io1-f67.google.com with SMTP id k18so23152754ion.0 for ; Tue, 26 May 2020 11:08:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ShRmryyfPituzUaTF9xqzITMDWyV5MMJxj9+4c5azDc=; b=Wwb5yQDuFmR+fqLSOnkXrXl0DPi3r4PmRl6FM3ueoBdBnBR/ek3AlG+Zbwhf2Dht0w jl4sP9oWBwlbEl5O3qTz2LPLktQpiBhhiJyyu6UJeGm3gpSWINDc7WzZLHXqYiPcsv0J aUPfvRONunlIFWEp/tQW2i2xQHFF/CC04vYTUwYmCWq4ujcpMcDYB4kWbqJEYNbEF+Wd l006NMIpSaVRHZXkgHAHYKt5BReBwlOCMkUwGolquXSIwoXCLWgYlBhF//Rx2U3nlc8b VLsbJprr5q+FWIRGYHypjQ6z0PJo+6GRLZlTb1xuKWO44pAbIQGpnTxIBxCqTMH9HWqO 36+w== X-Gm-Message-State: AOAM531zDcuwrdSakbe2aCz5lWxhIMIJsbWPgow/HS12azJPQK6xzZFb 1mF0yj54IUZP4aJG8ONo1w== X-Google-Smtp-Source: ABdhPJw3FHEFautJYIk4tPlQQMhfWPm80jnVw4i0iIIULhGB0bIvWnQ4K1CyzKMAwU5hjhBOO6TKQA== X-Received: by 2002:a05:6602:134d:: with SMTP id i13mr18153812iov.50.1590516525215; Tue, 26 May 2020 11:08:45 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id z13sm324592ilh.82.2020.05.26.11.08.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 11:08:44 -0700 (PDT) Received: (nullmailer pid 91004 invoked by uid 1000); Tue, 26 May 2020 18:08:43 -0000 Date: Tue, 26 May 2020 12:08:43 -0600 From: Rob Herring To: Alim Akhtar Subject: Re: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Message-ID: <20200526180843.GA81537@bogus> References: <20200514003914.26052-1-alim.akhtar@samsung.com> <20200514003914.26052-9-alim.akhtar@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200514003914.26052-9-alim.akhtar@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200526_110846_989518_D3FC5284 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-scsi@vger.kernel.org, martin.petersen@oracle.com, linux-kernel@vger.kernel.org, krzk@kernel.org, kwmad.kim@samsung.com, avri.altman@wdc.com, cang@codeaurora.org, stanley.chu@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 14, 2020 at 06:09:12AM +0530, Alim Akhtar wrote: > This patch adds DT binding for samsung ufs hci Subject should indicate this is for Samsung in some way. > > Signed-off-by: Alim Akhtar > --- > .../bindings/ufs/samsung,exynos-ufs.yaml | 91 +++++++++++++++++++ > 1 file changed, 91 insertions(+) > create mode 100644 Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > new file mode 100644 > index 000000000000..eaa64cc32d52 > --- /dev/null > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/ufs/samsung,exynos-ufs.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung SoC series UFS host controller Device Tree Bindings > + > +maintainers: > + - Alim Akhtar > + > +description: | > + Each Samsung UFS host controller instance should have its own node. > + This binding define Samsung specific binding other then what is used > + in the common ufshcd bindings > + [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt > + > +properties: > + > + compatible: > + enum: > + - samsung,exynos7-ufs > + > + reg: > + items: > + - description: HCI register > + - description: vendor specific register > + - description: unipro register > + - description: UFS protector register > + > + reg-names: > + items: > + - const: hci > + - const: vs_hci > + - const: unipro > + - const: ufsp > + > + clocks: > + maxItems: 2 maxItems is redundant. > + items: > + - description: ufs link core clock > + - description: unipro main clock > + > + clock-names: > + maxItems: 2 Here too. > + items: > + - const: core_clk > + - const: sclk_unipro_main > + > + interrupts: > + maxItems: 1 > + > + phys: > + maxItems: 1 > + > + phy-names: > + maxItems: 1 What's the name? (Though a name is kind of pointless when there is only 1.) With those fixed, Reviewed-by: Rob Herring > + > +required: > + - compatible > + - reg > + - interrupts > + - phys > + - phy-names > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + ufs: ufs@15570000 { > + compatible = "samsung,exynos7-ufs"; > + reg = <0x15570000 0x100>, > + <0x15570100 0x100>, > + <0x15571000 0x200>, > + <0x15572000 0x300>; > + reg-names = "hci", "vs_hci", "unipro", "ufsp"; > + interrupts = ; > + clocks = <&clock_fsys1 ACLK_UFS20_LINK>, > + <&clock_fsys1 SCLK_UFSUNIPRO20_USER>; > + clock-names = "core_clk", "sclk_unipro_main"; > + pinctrl-names = "default"; > + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > + phys = <&ufs_phy>; > + phy-names = "ufs-phy"; > + }; > +... > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel