From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC2D0C433E1 for ; Wed, 27 May 2020 11:37:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB3BF208B6 for ; Wed, 27 May 2020 11:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zic/pqvx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB3BF208B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1aIXmvJm730ilxi7GX8fPQtcamXBYCOXZJbL+VWXF6I=; b=Zic/pqvxKt1Ix4 7KLXxwl3XxlDZp877e0EDFwh0nfAi9eLWVr5Vu57Y0d7fbFQVBzdZBsejro0jBQv/vRupnMajXBDP cB5NsJDfGFQFJBolC6vyBqkCMeAOX9tacfyiDmPyQT11e9TbVt268ewKriM0JaG7XAu7BHxxgjopP TCbqr4iQu43Ea9BbV6Xp61T/fNijJPOqP53meJfwP8cSjxfwBqlOjBLJPTsPQda6gaaw2ljeWN8m7 OmsHgWNvhm1HCXlUSRbL5rXJPSFai/jqt3HPdnCpN4ppvIt8+HY+tbk8V4waA2yNRF114D5N7B9bc KjATXNc6lkmiTqI4r6Gw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jduMw-0002aC-EN; Wed, 27 May 2020 11:37:10 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jduMt-0002ZI-NK for linux-arm-kernel@lists.infradead.org; Wed, 27 May 2020 11:37:09 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8F4BE55D; Wed, 27 May 2020 04:37:06 -0700 (PDT) Received: from gaia (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7F6CD3F305; Wed, 27 May 2020 04:37:05 -0700 (PDT) Date: Wed, 27 May 2020 12:37:03 +0100 From: Catalin Marinas To: Anshuman Khandual Subject: Re: [PATCH V3] arm64/cpufeature: Add get_arm64_ftr_reg_nowarn() Message-ID: <20200527113703.GD28101@gaia> References: <1590573876-19120-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1590573876-19120-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_043707_801522_3793D6B5 X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, suzuki.poulose@arm.com, linux-kernel@vger.kernel.org, Mark Brown , will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 27, 2020 at 03:34:36PM +0530, Anshuman Khandual wrote: > +/* > + * get_arm64_ftr_reg - Looks up a feature register entry using > + * its sys_reg() encoding. This calls get_arm64_ftr_reg_nowarn(). > + * > + * returns - Upon success, matching ftr_reg entry for id. > + * - NULL on failure but with an WARN_ON(). > + */ > +static struct arm64_ftr_reg *get_arm64_ftr_reg(u32 sys_id) > +{ > + struct arm64_ftr_reg *reg; > + > + reg = get_arm64_ftr_reg_nowarn(sys_id); > + > + /* > + * Can not really proceed when the search fails here. > + * Requesting for a non existent register search will > + * be an error. Warn but let it continue for now. > + */ > + WARN_ON(!reg); > + return reg; I find the comment here slightly confusing: cannot proceed but continue. Maybe something like: /* * Requesting a non-existent register search is an error. Warn * and let the caller handle it. */ Otherwise it looks fine: Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel