From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E4C8C433DF for ; Wed, 27 May 2020 12:36:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 209F8207CB for ; Wed, 27 May 2020 12:36:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="oahY6u7d" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 209F8207CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tPnwrxziNjIzTsv+XVLZcxve9SD+ALJRzsHnTrbuQ7k=; b=oahY6u7doE4ARm xYdNG4IThmJiL2gCwwImmI7Iort2PnJKjDRMXwEFLD7OW8v7NXj95ZyGO9qW3M/USfLThuRG0b6/f fX9u+xekZblgIYhlqJXry4SwUsoBQBD8QtcEbJKpryqntOH6FUJnKG7i6PWHA5DN5X1/YOj1zXdl3 YYr2NOY1/itmma8si5WBTfe4S9HMGOHTxUIuOgRITi+2AGPcrdrn2ml/ruTSH+O6i/gIfwYdB3d2Q mz2sCVo8vDIEeDi1LaqIdPaPErc39rCH7DDRdhMYWaBwEioIhfs2WN7ocKQFLl+0oyQ4diwAhAIKv Uwv2GQ6kPYpWL+EpEiBw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdvIT-0001Dp-89; Wed, 27 May 2020 12:36:37 +0000 Received: from 8bytes.org ([2a01:238:4383:600:38bc:a715:4b6d:a889] helo=theia.8bytes.org) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdvIQ-0001D9-7T for linux-arm-kernel@lists.infradead.org; Wed, 27 May 2020 12:36:35 +0000 Received: by theia.8bytes.org (Postfix, from userid 1000) id 78345247; Wed, 27 May 2020 14:36:24 +0200 (CEST) Date: Wed, 27 May 2020 14:36:22 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Subject: Re: [PATCH v2 0/4] PCI, iommu: Factor 'untrusted' check for ATS enablement Message-ID: <20200527123622.GI5221@8bytes.org> References: <20200520152201.3309416-1-jean-philippe@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200520152201.3309416-1-jean-philippe@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200527_053634_418377_A82D48DB X-CRM114-Status: GOOD ( 10.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.williamson@redhat.com, ashok.raj@intel.com, linux-pci@vger.kernel.org, robin.murphy@arm.com, hch@infradead.org, iommu@lists.linux-foundation.org, bhelgaas@google.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, baolu.lu@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 05:21:59PM +0200, Jean-Philippe Brucker wrote: > IOMMU drivers currently check themselves if a device is untrusted > (plugged into an external-facing port) before enabling ATS. Move the > check to drivers/pci. The only functional change should be to the AMD > IOMMU driver. With this change all IOMMU drivers block 'Translated' PCIe > transactions and Translation Requests from untrusted devices. > > Since v1 [1] I added tags, addressed comments on patches 1 and 3, and > fixed a regression in patch 3. > > [1] https://lore.kernel.org/linux-iommu/20200515104359.1178606-1-jean-philippe@linaro.org/ > > Jean-Philippe Brucker (4): > PCI/ATS: Only enable ATS for trusted devices > iommu/amd: Use pci_ats_supported() > iommu/arm-smmu-v3: Use pci_ats_supported() > iommu/vt-d: Use pci_ats_supported() > > include/linux/pci-ats.h | 3 +++ > drivers/iommu/amd_iommu.c | 12 ++++-------- > drivers/iommu/arm-smmu-v3.c | 20 +++++++------------- > drivers/iommu/intel-iommu.c | 9 +++------ > drivers/pci/ats.c | 18 +++++++++++++++++- > 5 files changed, 34 insertions(+), 28 deletions(-) Applied, thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel