From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748B5C433E0 for ; Thu, 28 May 2020 11:46:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DA7F20888 for ; Thu, 28 May 2020 11:46:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T9Dd/Q4Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DA7F20888 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gyyH5hT2Oc/1F5+A5TRi04jVxQVXrVT1frECQQRyzXU=; b=T9Dd/Q4Y2TrYOP iKvwAU2VoDojaLNuSvuqiX5+Zo8fECKImIFsEAgtrLhQKwpHLJXg3F2Q/BmWfgJ6dcYW5/nYfOTj/ nDt8Y3OCudHhQuUYZU7iqYbETK5pmYQ7jhSd/ppqAjs8/e/7ScSwJ50zGsMZqtUgLT5VVQSCBoSmJ ulqI0oo34vy1BgBNAb4mrQhBqVkMKEKohsTBitF89RhfISnDAryVPcd0A1T0VzKqIdHODB4LX5JDg A6WOs64S2eq505RxP72U7UcTa5Fle/4epp1KxKqCdkkPMswZuFYgEA707hwOPF5jNY1ewiSkZgGoS nEQD+Yckro6Rd45WWurA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeGzI-00043q-QA; Thu, 28 May 2020 11:46:16 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeGzF-000432-IS for linux-arm-kernel@lists.infradead.org; Thu, 28 May 2020 11:46:15 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jeGz2-0002tO-Rx; Thu, 28 May 2020 13:46:00 +0200 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jeGz0-0001oA-7h; Thu, 28 May 2020 13:45:58 +0200 Date: Thu, 28 May 2020 13:45:58 +0200 From: Marco Felsch To: Andy Shevchenko Subject: Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver Message-ID: <20200528114558.5decxsun2o65k2fr@pengutronix.de> References: <20200528090144.54033-1-fengping.yu@mediatek.com> <20200528090144.54033-3-fengping.yu@mediatek.com> <20200528102730.GK1634618@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200528102730.GK1634618@smile.fi.intel.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 13:44:39 up 195 days, 3:03, 196 users, load average: 0.02, 0.07, 0.10 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_044613_607872_52AF8325 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, Yingjoe Chen , Fengping Yu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On 20-05-28 13:27, Andy Shevchenko wrote: > On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote: > > From: "fengping.yu" > > > > This adds matrix keypad support for Mediatek SoCs. > > ... > > > +config KEYBOARD_MTK_KPD > > + tristate "MediaTek Keypad Support" > > + depends on ARCH_MEDIATEK || COMPILE_TEST > > > + select CONFIG_REGMAP_MMIO > > This is wrong. Why is this wrong? The driver uses the rmap-mmio functions. Thanks for the explanation =) Marco > > > + select INPUT_MATRIXKMAP > > ... > > > + ret = devm_add_action_or_reset(&pdev->dev, kpd_clk_disable, > > + keypad->clk); > > I would leave on one line (only 81 characters). > > > + if (ret) > > + return ret; > > -- > With Best Regards, > Andy Shevchenko > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel