From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73AAEC433DF for ; Thu, 28 May 2020 12:22:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A3DB20888 for ; Thu, 28 May 2020 12:22:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WGumgA3o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A3DB20888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FEBJTrk0Zqn/pGGmsLsql+uqSky6q5lbVAe5vg24t2I=; b=WGumgA3ov7pLxG SK2IW0UV1qGdQ7JYy+7fLw5FAozNZgqiNX9rlujbcDfsOz2s2akbuMl8DoTY1Vx30LeFPFQIplIkN KPl9GmMQ4pXsgvoHkHYsJcQQgrSRIAmAI2XHOPU169Dd5QIvSkN41FOMTnFTdy2zuUSyFSrgKYdzX 7rh/RWco472uw/Kz+i1jmfWNSqoG/HLoa6OmGJ8PWaAg/w7IMc+tkR/g0iO8+/m1+f47nCxoDuxZF +/qrgI0P3q7Nh+xYlBPwzpKRQ82rMkagUslw1f+LPQugA9Wbmz+Zxp8CBXJL1LDnQqTx/IPkEgXJx j/y10NBS7H5NeeoklWYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHYi-0005hM-Jl; Thu, 28 May 2020 12:22:52 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeHYg-0005gx-7z; Thu, 28 May 2020 12:22:51 +0000 IronPort-SDR: UGyaJ4naWK3FZ7BpKWK+HgzICkUBC0LgdP7GLaLOZIDpN3Qho8sObBq7j6b16Q+EXfz0/vkmfR 7hYngJzaDOlQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2020 05:22:47 -0700 IronPort-SDR: A3d785f1MX0R7l/E+smvmFj55G3TOUMleCHgan5saOuclYvpp83MCkk6Ke8WhCNtrEbqnDgWXP cxkwBA55WAIg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,444,1583222400"; d="scan'208";a="270834696" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 28 May 2020 05:22:45 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jeHYe-009QMX-Rx; Thu, 28 May 2020 15:22:48 +0300 Date: Thu, 28 May 2020 15:22:48 +0300 From: Andy Shevchenko To: Marco Felsch Subject: Re: [RESEND PATCH v11 2/3] drivers: input: keyboard: Add mtk keypad driver Message-ID: <20200528122248.GL1634618@smile.fi.intel.com> References: <20200528090144.54033-1-fengping.yu@mediatek.com> <20200528090144.54033-3-fengping.yu@mediatek.com> <20200528102730.GK1634618@smile.fi.intel.com> <20200528114558.5decxsun2o65k2fr@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200528114558.5decxsun2o65k2fr@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_052250_328106_AE2D5B18 X-CRM114-Status: GOOD ( 10.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , linux-mediatek@lists.infradead.org, linux-input@vger.kernel.org, Yingjoe Chen , Fengping Yu , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 01:45:58PM +0200, Marco Felsch wrote: > On 20-05-28 13:27, Andy Shevchenko wrote: > > On Thu, May 28, 2020 at 05:01:47PM +0800, Fengping Yu wrote: ... > > > + select CONFIG_REGMAP_MMIO > > > > This is wrong. > > Why is this wrong? The driver uses the rmap-mmio functions. In Kconfig CONFIG_ prefix is implied. There is no CONFIG_CONFIG_REGMAP_MMIO. > Thanks for the explanation =) Sorry, I think it's obvious... > > > + select INPUT_MATRIXKMAP -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel