From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35356C433DF for ; Thu, 28 May 2020 14:46:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 054B620814 for ; Thu, 28 May 2020 14:46:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="talAoqe+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 054B620814 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rgDyXQn3A6y3Zqd4x0ybAxdzhGactyb/afZzw9rfO0g=; b=talAoqe+weIpx6 7xDNJeXpaPx0dHaMsSRZHp0XpPz3n3DBLEAERkuI48OTQxELMOlovkI4mA6nukiXHcq3lhEK4aR+G PKz7sFiD9vUOvx3VMbx5lotKXEHa8vtG0xmlB5ZXK79hAlKokM8oLjvlhxu0hdjfO3N5rMshmzin8 ArG1eyLsmViPk3IyG8iJMUL1q0v1ESiFuoaRhTjFFRJlzc8wu6sl2Zi88/8SDEaloc7JO+ssbW0LO VoeRth9SJFvgEQXJ0KEG3nAtJy44POs5PlL5RTRtMz42pI1lrmTQOP2TNfpnl8RjW0f08+ycSrxa+ anIs1q/g/Ti/tlhURJRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJnS-00018T-Bl; Thu, 28 May 2020 14:46:14 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJn0-0000jo-BZ; Thu, 28 May 2020 14:45:47 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 620552A3D6A; Thu, 28 May 2020 15:45:44 +0100 (BST) Date: Thu, 28 May 2020 16:45:41 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200528164541.106bbde9@collabora.com> In-Reply-To: <20200528113113.9166-19-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_074546_554579_6E15326E X-CRM114-Status: GOOD ( 12.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal wrote: > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index ce936ffb9f42..1cc6d71c2b45 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -127,6 +127,10 @@ struct nand_page_io_req { > int mode; > }; > > +extern const struct mtd_ooblayout_ops nand_ooblayout_sp_ops; > +extern const struct mtd_ooblayout_ops nand_ooblayout_lp_ops; > +extern const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops; While we move that to the generic NAND layer, can we hide that behind helpers so we don't have the objects directly exposed? const struct mtd_ooblayout_ops *nand_get_small_page_layout(); const struct mtd_ooblayout_ops *nand_get_large_page_layout(); const struct mtd_ooblayout_ops *nand_get_large_page_hamming_layout(); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel