From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E652C433E1 for ; Thu, 28 May 2020 14:53:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45BE92075F for ; Thu, 28 May 2020 14:53:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mPkXa5RM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45BE92075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8oyTPEL/Z18AHi9qzyF2Dhge+gJQnP9gd6xDuupXsts=; b=mPkXa5RMgvpYkl pFS5yq1p6RZj27t8g/Mgx5MDsE9Chg2KtyXBTMJ17rZsCSHlk6uZiIwHMCY7IARhLbmapBspRjZce 1WIkBAIa2n70dvboScvgs9mkNR7nriFAC2JMWvcZzs5NaM24cr802BcR+K4viqJTG/vcmf0s9/gaH ADAGpC5Lt4knWWiu7qmabbQYwm4pmp0C2olStRDXVXpqOUB6OFA14PxRcGlWk1QM5k8XtlAgX1MIB 7HEsWQGy4e7YfNMZni1jhIIxh0pTMC3TG3j4Jo+C17IE9SfkTgMCFMqGwvFvj8YGA2IBLFRCwSn39 WpEGmKYExznSqEox0Cuw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJuS-0006y3-TO; Thu, 28 May 2020 14:53:28 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeJuP-0006xU-GD; Thu, 28 May 2020 14:53:26 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id C190F20000C; Thu, 28 May 2020 14:53:17 +0000 (UTC) Date: Thu, 28 May 2020 16:53:16 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v6 17/18] mtd: rawnand: Write a compatibility layer Message-ID: <20200528165316.647f9cb0@xps13> In-Reply-To: <20200528164217.4eec33ae@collabora.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-18-miquel.raynal@bootlin.com> <20200528164217.4eec33ae@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_075325_668462_AFCEA58C X-CRM114-Status: UNSURE ( 9.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Thu, 28 May 2020 16:42:17 +0200: > On Thu, 28 May 2020 13:31:12 +0200 > Miquel Raynal wrote: > > > +static enum nand_ecc_engine_type > > +of_get_rawnand_ecc_engine_type_legacy(struct device_node *np) > > +{ > > + enum nand_ecc_legacy_mode { > > + NAND_ECC_INVALID, > > + NAND_ECC_NONE, > > + NAND_ECC_SOFT, > > + NAND_ECC_SOFT_BCH, > > + NAND_ECC_HW, > > + NAND_ECC_HW_SYNDROME, > > + NAND_ECC_ON_DIE, > > + }; > > You're redefining an enum, but I don't see the old enum/defines being > removed, is that expected? Oh yeah, my desire was to get rid of this public enumeration and mov it to the single legacy function using it, but indeed I am removing it in the next patch as part of the global move to nand/core.c. I will do it in this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel