From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35176C433E0 for ; Thu, 28 May 2020 15:01:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0822A2075F for ; Thu, 28 May 2020 15:01:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hqGjcgx1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0822A2075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X4GEM6rAWmVmJ0rKIUUFgMxgqfzH63MHjf7UEFrq9XQ=; b=hqGjcgx1Ry+FUB 3ed59nwpMLnsJoXqOE92iq3kq0VgmEoZmFnOKS2InF5Wiv4hOiaHUpgECjfoKWzdgDVa5aaa3NlCi Wm8QzCyyb2ZfW3+3YVog3wuIOsKhDFVSOzqEOEIV9s69FprANtRO86rJybl8NXodyEXicEYFdW4Z1 ecz5hVFmRq6ZbAYXeusH1UIcS95Tthvjj9T6K2eBB0k5g/5fm3Z979ozaBODbLAiiwDQn3LV2G7zO GKkNObabWCugR4CsRCK6aFA0ZfppaXhQXe5NrL3DedQPxWJnvH5M42GbZLGdb1JR20Qz0Lf4KbZyF 4yf2aw3JWmLtgRqKDilQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeK2M-000776-0x; Thu, 28 May 2020 15:01:38 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeK1D-0006l8-Au; Thu, 28 May 2020 15:00:29 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id B08972A3FE2; Thu, 28 May 2020 16:00:25 +0100 (BST) Date: Thu, 28 May 2020 17:00:22 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v6 14/18] mtd: nand: Add more parameters to the nand_ecc_props structure Message-ID: <20200528170022.5cd5b46c@collabora.com> In-Reply-To: <20200528165754.35985b62@xps13> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-15-miquel.raynal@bootlin.com> <20200528163424.6677597c@collabora.com> <20200528165754.35985b62@xps13> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_080027_512771_4FDFD9AC X-CRM114-Status: GOOD ( 22.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 May 2020 16:57:54 +0200 Miquel Raynal wrote: > Boris Brezillon wrote on Thu, 28 May > 2020 16:34:24 +0200: > > > On Thu, 28 May 2020 13:31:09 +0200 > > Miquel Raynal wrote: > > > > > Prepare the migration to the generic ECC framework by adding more > > > fields to the nand_ecc_props structure which will be used widely to > > > describe different kind of ECC properties. > > > > > > Doing this imposes to move the engine type, ECC placement and > > > algorithm enumerations in a shared place: nand.h. > > > > > > Signed-off-by: Miquel Raynal > > > --- > > > include/linux/mtd/nand.h | 52 +++++++++++++++++++++++++++++++++++++ > > > include/linux/mtd/rawnand.h | 44 ------------------------------- > > > 2 files changed, 52 insertions(+), 44 deletions(-) > > > > > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > > > index 6add464fd18b..2e9af24936cd 100644 > > > --- a/include/linux/mtd/nand.h > > > +++ b/include/linux/mtd/nand.h > > > @@ -127,14 +127,66 @@ struct nand_page_io_req { > > > int mode; > > > }; > > > > > > +/** > > > + * enum nand_ecc_engine_type - NAND ECC engine type > > > + * @NAND_ECC_ENGINE_TYPE_INVALID: Invalid value > > > + * @NAND_ECC_ENGINE_TYPE_NONE: No ECC correction > > > + * @NAND_ECC_ENGINE_TYPE_SOFT: Software ECC correction > > > + * @NAND_ECC_ENGINE_TYPE_ON_HOST: On host hardware ECC correction > > > + * @NAND_ECC_ENGINE_TYPE_ON_DIE: On chip hardware ECC correction > > > + */ > > > +enum nand_ecc_engine_type { > > > + NAND_ECC_ENGINE_TYPE_INVALID, > > > + NAND_ECC_ENGINE_TYPE_NONE, > > > + NAND_ECC_ENGINE_TYPE_SOFT, > > > + NAND_ECC_ENGINE_TYPE_ON_HOST, > > > + NAND_ECC_ENGINE_TYPE_ON_DIE, > > > +}; > > > + > > > +/** > > > + * enum nand_ecc_placement - NAND ECC bytes placement > > > + * @NAND_ECC_PLACEMENT_UNKNOWN: The actual position of the ECC bytes is unknown > > > + * @NAND_ECC_PLACEMENT_OOB: The ECC bytes are located in the OOB area > > > + * @NAND_ECC_PLACEMENT_INTERLEAVED: Syndrome layout, there are ECC bytes > > > + * interleaved with regular data in the main > > > + * area > > > + */ > > > +enum nand_ecc_placement { > > > + NAND_ECC_PLACEMENT_UNKNOWN, > > > + NAND_ECC_PLACEMENT_OOB, > > > + NAND_ECC_PLACEMENT_INTERLEAVED, > > > +}; > > > + > > > +/** > > > + * enum nand_ecc_algo - NAND ECC algorithm > > > + * @NAND_ECC_ALGO_UNKNOWN: Unknown algorithm > > > + * @NAND_ECC_ALGO_HAMMING: Hamming algorithm > > > + * @NAND_ECC_ALGO_BCH: Bose-Chaudhuri-Hocquenghem algorithm > > > + * @NAND_ECC_ALGO_RS: Reed-Solomon algorithm > > > + */ > > > +enum nand_ecc_algo { > > > + NAND_ECC_ALGO_UNKNOWN, > > > + NAND_ECC_ALGO_HAMMING, > > > + NAND_ECC_ALGO_BCH, > > > + NAND_ECC_ALGO_RS, > > > +}; > > > + > > > /** > > > * struct nand_ecc_props - NAND ECC properties > > > + * @engine_type: ECC engine type > > > + * @placement: OOB placement (if relevant) > > > + * @algo: ECC algorithm (if relevant) > > > * @strength: ECC strength > > > * @step_size: Number of bytes per step > > > + * @flags: Misc properties > > > > I'd like to hear more about that one. What is this about? I'd rather > > not add a field if it's not needed. > > > > It is used in patch 18/18 to store the NAND_ECC_MAXIMIZE flag. And I > expect others to come later... Then I think it should be introduced in this patch, not here. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel