From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEE1AC433E0 for ; Thu, 28 May 2020 15:04:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9148F2075F for ; Thu, 28 May 2020 15:04:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DxKm6qKa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9148F2075F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GAp9kfNboywAIBnDh7ew8mq7zTFJjmYUjDgJ87jFS0o=; b=DxKm6qKa8kMoSh rprO/zCUMgTKEZSdcHW82NeCcQaZ5XnAnFSybJv8NyiXpSuVrPjiM4HKxo7WebUkKIMCWp+Zg/lWt ciJk7XNHXMDA3hWsfFTqORPF/7yr0vyVdw6/4TGyDNxlVNmBsTMyYwC210cLmiTTLJIyKyGUB20Do z79n9MV+aplJOMnOMvzom5np9eCsYEYd0WOQZxBKuevZxuO+DsN0Ly8MimB7pSPOmNaV7M4lagMXY 7liKKX5KwRsU88EWYlu1yYHf3IUIXgs9hJRwFrplDSooqR3iWIcMIumF6u5f57F6o8smpABugur4p P980iVPcW3ENKRWF2e3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeK5U-00014f-Lp; Thu, 28 May 2020 15:04:52 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeK53-0000oP-0d; Thu, 28 May 2020 15:04:27 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id A9D7A240003; Thu, 28 May 2020 15:04:20 +0000 (UTC) Date: Thu, 28 May 2020 17:04:19 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v6 16/18] mtd: nand: Convert generic NAND bits to use the ECC framework Message-ID: <20200528170419.0c2ba99a@xps13> In-Reply-To: <20200528165217.6582f9aa@collabora.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-17-miquel.raynal@bootlin.com> <20200528163907.6539e2a1@collabora.com> <20200528164926.3b99f848@xps13> <20200528165217.6582f9aa@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_080425_350476_35D161A9 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Thu, 28 May 2020 16:52:17 +0200: > On Thu, 28 May 2020 16:49:26 +0200 > Miquel Raynal wrote: > > > Boris Brezillon wrote on Thu, 28 May > > 2020 16:39:07 +0200: > > > > > On Thu, 28 May 2020 13:31:11 +0200 > > > Miquel Raynal wrote: > > > > > > > Embed a generic NAND ECC high-level object in the nand_device > > > > structure to carry all the ECC engine configuration/data. Adapt the > > > > raw NAND and SPI-NAND cores to fit the change. > > > > > > > > Signed-off-by: Miquel Raynal > > > > --- > > > > drivers/mtd/nand/Kconfig | 1 + > > > > drivers/mtd/nand/raw/atmel/nand-controller.c | 9 +++-- > > > > drivers/mtd/nand/raw/brcmnand/brcmnand.c | 7 ++-- > > > > drivers/mtd/nand/raw/gpmi-nand/gpmi-nand.c | 12 +++--- > > > > drivers/mtd/nand/raw/marvell_nand.c | 7 ++-- > > > > drivers/mtd/nand/raw/mtk_nand.c | 4 +- > > > > drivers/mtd/nand/raw/nand_base.c | 25 ++++++------ > > > > drivers/mtd/nand/raw/nand_esmt.c | 11 +++--- > > > > drivers/mtd/nand/raw/nand_hynix.c | 41 ++++++++++---------- > > > > drivers/mtd/nand/raw/nand_jedec.c | 4 +- > > > > drivers/mtd/nand/raw/nand_micron.c | 14 ++++--- > > > > drivers/mtd/nand/raw/nand_onfi.c | 8 ++-- > > > > drivers/mtd/nand/raw/nand_samsung.c | 19 ++++----- > > > > drivers/mtd/nand/raw/nand_toshiba.c | 11 +++--- > > > > drivers/mtd/nand/raw/sunxi_nand.c | 5 ++- > > > > drivers/mtd/nand/raw/tegra_nand.c | 9 +++-- > > > > drivers/mtd/nand/spi/core.c | 8 ++-- > > > > drivers/mtd/nand/spi/macronix.c | 6 +-- > > > > drivers/mtd/nand/spi/toshiba.c | 6 +-- > > > > include/linux/mtd/nand.h | 8 ++-- > > > > 20 files changed, 115 insertions(+), 100 deletions(-) > > > > > > > > diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig > > > > index a4478ffa279d..3327d8539a73 100644 > > > > --- a/drivers/mtd/nand/Kconfig > > > > +++ b/drivers/mtd/nand/Kconfig > > > > @@ -13,6 +13,7 @@ menu "ECC engine support" > > > > > > > > config MTD_NAND_ECC > > > > bool > > > > + select MTD_NAND_CORE > > > > > > This select looks suspicious. Shouldn't it be a depends on, and more > > > importantly, I think it should be part of patch 15. > > > > Wouldn't we break a lot of users by using depends on? > > > > Or maybe we can turn it on by default? > > It's a sub-functionality of the NAND core, so it should be a depends on > in my opinion. Why would that break users. Aren't you selecting > MTD_NAND_CORE in MTD_RAWNAND now? Those options should really remain > hidden, and be selected at the SPI/raw NAND framework level. I remembered we discussed that point already, yes the generic core is selected by the SPI/raw NAND layers, so it should be fine. I'll move this as a depends on in the previous patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel