From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C4FC433DF for ; Thu, 28 May 2020 15:55:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66F692053B for ; Thu, 28 May 2020 15:55:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Y4DFgeHk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 66F692053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZfweAYICcyCBOZFcC+hlpedkhmQen7aWZcrFm3BK43Q=; b=Y4DFgeHkqR17EB FMZ73LVSA58i19LBH4JIVAlo2u853RJrkls5xm5dsrSREzLa1WZvO4I/2rJVNkMz/anYKfw7pALlV 8zZU+wtggErJrh3lwgDdUB03KXr3W4bZidjZZOFaW7LVH6tnKoRoIQqeer3AlhQY2PMYHF8KMfkci uA34tM/Dzb9TFXuZ9u0tOPR3Iw0VFqqdtvY+Ans8SELQV4Vs0+Z+lQwUfw8DAqNgBN05EVO8Zxiu4 dgKutLmrC4s6ltF+jGtq92BRAyVA0guyd1fk6Hp0OzXc2VdYOL1LWC66QoN/BJ8EeN+6Jtdtr3hbw gB4TW/issOm9mjrZ4Tpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKsr-000316-FH; Thu, 28 May 2020 15:55:53 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeKsX-0002lh-Qd; Thu, 28 May 2020 15:55:36 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 791982A4023; Thu, 28 May 2020 16:55:31 +0100 (BST) Date: Thu, 28 May 2020 17:55:27 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v6 18/18] mtd: rawnand: Move generic bits to the ECC framework Message-ID: <20200528175527.7be7af00@collabora.com> In-Reply-To: <20200528113113.9166-19-miquel.raynal@bootlin.com> References: <20200528113113.9166-1-miquel.raynal@bootlin.com> <20200528113113.9166-19-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_085534_014797_8D04F2C7 X-CRM114-Status: GOOD ( 13.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , Weijie Gao , Paul Cercueil , Rob Herring , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , Chuanhong Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 28 May 2020 13:31:13 +0200 Miquel Raynal wrote: > Many OOB layouts and helpers are generic to all NAND chips, they > should not be restricted to be only used by raw NAND controller > drivers. They might later be used by generic ECC engines and SPI-NAND > devices as well so move them into a more generic place. > > To avoid moving all the raw NAND core "history" into the generic NAND > layer, we already moved certain bits into legacy helpers in the raw > NAND core to ensure backward compatibility. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/Kconfig | 11 + > drivers/mtd/nand/Makefile | 1 + > .../mtd/nand/{raw/nand_bch.c => ecc-sw-bch.c} | 2 +- > drivers/mtd/nand/ecc.c | 299 +++++++++++++++++ > drivers/mtd/nand/raw/Kconfig | 11 +- > drivers/mtd/nand/raw/Makefile | 1 - > drivers/mtd/nand/raw/atmel/nand-controller.c | 3 +- > drivers/mtd/nand/raw/denali.c | 3 + > drivers/mtd/nand/raw/nand_base.c | 313 +----------------- > drivers/mtd/nand/raw/nand_toshiba.c | 2 + > drivers/mtd/nand/raw/nandsim.c | 2 +- > drivers/mtd/nand/raw/omap2.c | 2 +- > drivers/mtd/nand/raw/sunxi_nand.c | 3 +- > drivers/mtd/nand/raw/tegra_nand.c | 3 +- > .../mtd/{nand_bch.h => nand-ecc-sw-bch.h} | 6 +- > include/linux/mtd/nand.h | 20 ++ > include/linux/mtd/rawnand.h | 17 +- > 17 files changed, 364 insertions(+), 335 deletions(-) > rename drivers/mtd/nand/{raw/nand_bch.c => ecc-sw-bch.c} (99%) > rename include/linux/mtd/{nand_bch.h => nand-ecc-sw-bch.h} (92%) I feel like this patch could be split a little. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel