From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 100E1C433E0 for ; Thu, 28 May 2020 22:01:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3481206F1 for ; Thu, 28 May 2020 22:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eeYfEU/G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3481206F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mvVmXnx5+5LjqYVxC9vnCkRyClNNaJDQ43g86BKDBVc=; b=eeYfEU/GhwDc7B hvuE35XC/8/h2HXTDLTsTwuELpfOlb1SQfC9rjxpo8nwtS3cHemiT4oO1AJ6vKvxP5uU0Id+8UXyk VDwpZRatyPM936SEjdub9eJ8BYarLTA0t0azKiOO7a+2YtN8CewWrU3lUUidwxYvs30gIy5Fq48wW EYkjMcOg8giF/aw05EeMTM0s3a0Tynu4nQyTPuE0yn+HjO2RLix8SQFDgIyBsEV5RoB/7I2shDvLr O+gCh1Zcqp73f1DnceB4r0H88E67efg2SeyUOs138K9NJHlEDS81pR8v2dJnpFNiOqvpN+8Xkf6uQ iF+wnEDVCGGm+9W9VTrA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeQas-0000S4-9T; Thu, 28 May 2020 22:01:42 +0000 Received: from mail-il1-f194.google.com ([209.85.166.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeQap-0000Ri-PC; Thu, 28 May 2020 22:01:41 +0000 Received: by mail-il1-f194.google.com with SMTP id 17so529372ilj.3; Thu, 28 May 2020 15:01:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=ypTe2PhllcbFDiwKFVMlag8IDVx6GgqoGKohXERCZBQ=; b=pl4KBLYQ/DTFaOsasyn+KA7ay2AcpQmkm94QK0TiWEVwkn+77c9FIwptSWzlgdohqY +QcZOYYI4aAtWTDh7mgLUy186ZZUBKSnwA+Ph58KbiWkdquLmzjN72HfgBlv/Yx9xNrR Cy7CXxjrNEncy6lqfuH9cjb9PM2zS0VN5on95Y+z8CSRPcYgMCf/fqwDoZEG+CSfcPT/ /CabGiTdX3zeTbKt9FdUwZ9673dQ9Kycyc2WHbSNs3LA0PqsZS2apqNGEMxJDqKjMvtc mtLDxwvclSZBMGhH5gISWJfbfnT1PDE0zdQBkdy0jLbXolYpZ5+qiOE/XGi8AJxsm+jX p6rg== X-Gm-Message-State: AOAM533w98QVtSb0cMIzjXKG6OquEmDehIvGdwVU/1P57nNGQYAnmd87 lDkM5yz3Bo3Pnofex/zULXH/GGo= X-Google-Smtp-Source: ABdhPJzFT3oU/vjsNRn309VDH/DNiO+Z5WPTFKoWeipwpTJAZ6V1gzsWGOibx8+mO77rr6DZOlHjqA== X-Received: by 2002:a92:2801:: with SMTP id l1mr5040474ilf.132.1590703298885; Thu, 28 May 2020 15:01:38 -0700 (PDT) Received: from xps15 ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id f9sm3853884ile.39.2020.05.28.15.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2020 15:01:38 -0700 (PDT) Received: (nullmailer pid 760172 invoked by uid 1000); Thu, 28 May 2020 22:01:36 -0000 Date: Thu, 28 May 2020 16:01:36 -0600 From: Rob Herring To: Heiko =?iso-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] dt-bindings: input: touchscreen: edt-ft5x06: change reg property Message-ID: <20200528220136.GA748777@bogus> References: <20200520073327.6016-1-jbx6244@gmail.com> <20200520171324.GS89269@dtor-ws> <4727344.YYj2SkWT1V@diego> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4727344.YYj2SkWT1V@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200528_150139_817205_7ADDA9F0 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-input@vger.kernel.org, Johan Jonker , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 20, 2020 at 08:41:59PM +0200, Heiko St=FCbner wrote: > Hi Dmitry, > = > Am Mittwoch, 20. Mai 2020, 19:13:24 CEST schrieb Dmitry Torokhov: > > Hi Johan, > > = > > On Wed, May 20, 2020 at 09:33:27AM +0200, Johan Jonker wrote: > > > A test with the command below gives this error: > > > = > > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: > > > touchscreen@3e: reg:0:0: 56 was expected > > > = > > > The touchscreen chip on 'rk3188-bqedison2qc' and other BQ models > > > was shipped with different addresses then the binding currently allow= s. > > > Change the reg property that any address will pass. > > > = > > > make ARCH=3Darm dtbs_check > > > DT_SCHEMA_FILES=3DDocumentation/devicetree/bindings/input/touchscreen/ > > > edt-ft5x06.yaml > > > = > > > Signed-off-by: Johan Jonker > > > --- > > > Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml = | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > = > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-= ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x0= 6.yaml > > > index 383d64a91..baa8e8f7e 100644 > > > --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.= yaml > > > +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.= yaml > > > @@ -42,7 +42,7 @@ properties: > > > - focaltech,ft6236 > > > = > > > reg: > > > - const: 0x38 > > > + maxItems: 1 > > = > > Should we have a list of valid addresses instead of allowing any > > address? Controllers usually have only a couple of addresses that they > > support. > = > from what I've read, the fdt touchscreen controllers are just a generic > cpu with device-specific (or better panel-specific) firmware, which seems > to include the address as well - so it looks to be variable. > = > But of course that is only 2nd hand knowledge for me ;-) > = > = > But also, the i2c address is something you cannot really mess up, > either it is correct and your touchscreen works, or it isn't and and > adding entries to this list every time a new address variant pops up > feels clumsy. Is that an Ack? I'm fine either way. It's really only useful if there's a single = address because with a list it could still be wrong just as any other = data like an interrupt number could be wrong. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel