* [PATCH] net: ethernet: mtk-star-emac: remove unused variable
@ 2020-05-29 8:26 Bartosz Golaszewski
2020-05-29 8:27 ` Bartosz Golaszewski
2020-05-29 19:42 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-05-29 8:26 UTC (permalink / raw)
To: John Crispin, Sean Wang, Mark Lee, David S . Miller,
Jakub Kicinski, Matthias Brugger
Cc: kbuild test robot, Stephane Le Provost, Bartosz Golaszewski,
netdev, linux-kernel, Fabien Parent, linux-mediatek,
Andrew Perepech, Pedro Tsai, linux-arm-kernel
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
The desc pointer is set but not used. Remove it.
Reported-by: kbuild test robot <lkp@intel.com>
Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
index 8596ca0e60eb..7df35872c107 100644
--- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
+++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
@@ -746,15 +746,12 @@ mtk_star_ring_free_skbs(struct mtk_star_priv *priv, struct mtk_star_ring *ring,
struct mtk_star_ring_desc_data *))
{
struct mtk_star_ring_desc_data desc_data;
- struct mtk_star_ring_desc *desc;
int i;
for (i = 0; i < MTK_STAR_RING_NUM_DESCS; i++) {
if (!ring->dma_addrs[i])
continue;
- desc = &ring->descs[i];
-
desc_data.dma_addr = ring->dma_addrs[i];
desc_data.skb = ring->skbs[i];
--
2.26.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: mtk-star-emac: remove unused variable
2020-05-29 8:26 [PATCH] net: ethernet: mtk-star-emac: remove unused variable Bartosz Golaszewski
@ 2020-05-29 8:27 ` Bartosz Golaszewski
2020-05-29 19:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2020-05-29 8:27 UTC (permalink / raw)
To: John Crispin, Sean Wang, Mark Lee, David S . Miller,
Jakub Kicinski, Matthias Brugger
Cc: kbuild test robot, Stephane Le Provost, Bartosz Golaszewski,
netdev, Linux Kernel Mailing List, Fabien Parent,
moderated list:ARM/Mediatek SoC..., Andrew Perepech, Pedro Tsai,
Linux ARM
pt., 29 maj 2020 o 10:26 Bartosz Golaszewski <brgl@bgdev.pl> napisał(a):
>
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The desc pointer is set but not used. Remove it.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 8596ca0e60eb..7df35872c107 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -746,15 +746,12 @@ mtk_star_ring_free_skbs(struct mtk_star_priv *priv, struct mtk_star_ring *ring,
> struct mtk_star_ring_desc_data *))
> {
> struct mtk_star_ring_desc_data desc_data;
> - struct mtk_star_ring_desc *desc;
> int i;
>
> for (i = 0; i < MTK_STAR_RING_NUM_DESCS; i++) {
> if (!ring->dma_addrs[i])
> continue;
>
> - desc = &ring->descs[i];
> -
> desc_data.dma_addr = ring->dma_addrs[i];
> desc_data.skb = ring->skbs[i];
>
> --
> 2.26.1
>
Cr*p I forgot to tag it for net-next. David let me know if you want me
to resend it.
Bartosz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: ethernet: mtk-star-emac: remove unused variable
2020-05-29 8:26 [PATCH] net: ethernet: mtk-star-emac: remove unused variable Bartosz Golaszewski
2020-05-29 8:27 ` Bartosz Golaszewski
@ 2020-05-29 19:42 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-05-29 19:42 UTC (permalink / raw)
To: brgl
Cc: lkp, stephane.leprovost, bgolaszewski, netdev, sean.wang,
linux-kernel, fparent, pedro.tsai, linux-mediatek,
andrew.perepech, john, matthias.bgg, kuba, Mark-MC.Lee,
linux-arm-kernel
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Fri, 29 May 2020 10:26:48 +0200
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The desc pointer is set but not used. Remove it.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-29 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-29 8:26 [PATCH] net: ethernet: mtk-star-emac: remove unused variable Bartosz Golaszewski
2020-05-29 8:27 ` Bartosz Golaszewski
2020-05-29 19:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).