From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1BFC433E0 for ; Fri, 29 May 2020 14:50:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A836F20776 for ; Fri, 29 May 2020 14:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LrqJMkSz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VApd29jC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A836F20776 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aQGwAxAo0wgs1xomyWO3yZUt0Q2+FPB60TEs/EFJ7pU=; b=LrqJMkSzTb4U3+ HOuTCTNf3Z63O6EBGfrk4f2tPS1/Ii69tv/61pKH++0OSlwAZTcf84btDEdsfnUCA9d4o9Jx7sFCA Xbie7bWsCfREcBkN5TWNJXAEr22s0uuy9kv/zYtTTpv9eIh46iQ5p6pVImlNRJf3TuGVKzJK59eyK dvyvU6peKuZzzmat5yVw3eyOcvblgBd3OF6btdLodt+wrb6xdW7eJTnwRrClF0Rb6FJ0KkuLhwlPs G+ucRhQjJCwAtGlYlHnBOIunHlH6WVeg5RB4n3os3hjkJDcT1YCCpuDJ0Q8JbMNQ2mQIoGknkVfSm WJfzS94kXWpq+EALSRVA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jegKx-0004nh-8n; Fri, 29 May 2020 14:50:19 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jegKu-0004mY-B2; Fri, 29 May 2020 14:50:17 +0000 Received: by mail-pl1-x641.google.com with SMTP id x18so1243271pll.6; Fri, 29 May 2020 07:50:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ckAKropeOCUm1zmt0HIr3BWF9IN5QnUNbPwdDc91gQM=; b=VApd29jCPL4t/dmJjYuL4RaTRnmPGPnedoBqJignh4pwfT+adxmEfTg6KII8hVU3+y P+HgN3s66RdiqfaK5p5d5Yb+BT/bbTfelEz53DfeySa6BOi8Nz7ffDOzXCWc89PjESDx j6npuyY26G43teVevipd+CCGm4HtCtJrWRFgp4B5iTes87Z/DOyGYha+cTN2aS6Yq7+g UIcmEP7iCNmgbhNY34/sjXKt1JDcShF6tnfO6arWC71pCNhSjMtPj7a+U0UGOqyJbLTn eXE2kLLF08hY0We0hSvVFKsCyOel7J8thLG3PvUb5jL/2Zf8PvzV6kVN8vl8lNQ2kvTd uw2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=ckAKropeOCUm1zmt0HIr3BWF9IN5QnUNbPwdDc91gQM=; b=fchPDEWbhZwKFvXrXqCQvBIETpnmNZvW8dZu0cFb7FjsZXhfcUD2ncteuApUDpH4Kz +dO2W2njm6q7+qQcuwhG95U+FdviutXg52CHfKfKcFsIs+qGg4i9HiNxxB3sLJnWO5uP QIuPLLgxhkwzQBEeXB1ITj7nSWZHW2m+8gLQ9T8gpG/kQB2AmtIAYmpHs/ZzEOjaa8QV aOOY06M9gfI7GYZGq/0ij7ZxFLSPGXErk3M1V/ijUOBy4/Q2vW/f0ipf6KaTm8rc5ATa HyY0z6Bj9eghMa1RVZBYYjGVIntNtlALvx2BtrSFq9Tc8nFh/fegoM744f9y07gl+44i 5W2A== X-Gm-Message-State: AOAM530OkdPi1KOTjuSnQIWocR3Zz/jzvnAp6nNjMZqjfikmBRGdcQRY i+eMcAfVEtfsSqSUt/wcEBc= X-Google-Smtp-Source: ABdhPJxKeEIcZPHMl4KTv3Kl/4nwkc/Lyd2ImrMkBUvZkzIyDKXQUYsPEnihKLG8uevhr4cQxpz+iw== X-Received: by 2002:a17:90a:4805:: with SMTP id a5mr4970593pjh.22.1590763815238; Fri, 29 May 2020 07:50:15 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 140sm4674978pfy.95.2020.05.29.07.50.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 29 May 2020 07:50:14 -0700 (PDT) Date: Fri, 29 May 2020 07:50:13 -0700 From: Guenter Roeck To: Andrzej Pietrasiewicz Subject: Re: [PATCH v4 01/11] acpi: thermal: Fix error handling in the register function Message-ID: <20200529145013.GA125062@roeck-us.net> References: <4493c0e4-51aa-3907-810c-74949ff27ca4@samsung.com> <20200528192051.28034-1-andrzej.p@collabora.com> <20200528192051.28034-2-andrzej.p@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200528192051.28034-2-andrzej.p@collabora.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_075016_385246_1546CCAE X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emmanuel Grumbach , Heiko Stuebner , Kalle Valo , linux-wireless@vger.kernel.org, Peter Kaestle , platform-driver-x86@vger.kernel.org, Vishal Kulkarni , Luca Coelho , Miquel Raynal , Shawn Guo , kernel@collabora.com, Fabio Estevam , Amit Kucheria , linux-rockchip@lists.infradead.org, Chunyan Zhang , Daniel Lezcano , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Darren Hart , Zhang Rui , Gayatri Kammela , NXP Linux Team , Johannes Berg , linux-pm@vger.kernel.org, Sascha Hauer , Intel Linux Wireless , Ido Schimmel , Niklas =?iso-8859-1?Q?S=F6derlund?= , Jiri Pirko , Orson Zhai , Thomas Gleixner , Allison Randal , Support Opensource , netdev@vger.kernel.org, "Rafael J . Wysocki" , Sebastian Reichel , linux-renesas-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , Pengutronix Kernel Team , Baolin Wang , Len Brown , Enrico Weigelt , "David S . Miller" , Andy Shevchenko Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 28, 2020 at 09:20:41PM +0200, Andrzej Pietrasiewicz wrote: > The acpi_thermal_register_thermal_zone() is missing any error handling. > This needs to be fixed. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Guenter Roeck > --- > drivers/acpi/thermal.c | 20 ++++++++++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c > index 19067a5e5293..6de8066ca1e7 100644 > --- a/drivers/acpi/thermal.c > +++ b/drivers/acpi/thermal.c > @@ -901,23 +901,35 @@ static int acpi_thermal_register_thermal_zone(struct acpi_thermal *tz) > result = sysfs_create_link(&tz->device->dev.kobj, > &tz->thermal_zone->device.kobj, "thermal_zone"); > if (result) > - return result; > + goto unregister_tzd; > > result = sysfs_create_link(&tz->thermal_zone->device.kobj, > &tz->device->dev.kobj, "device"); > if (result) > - return result; > + goto remove_tz_link; > > status = acpi_bus_attach_private_data(tz->device->handle, > tz->thermal_zone); > - if (ACPI_FAILURE(status)) > - return -ENODEV; > + if (ACPI_FAILURE(status)) { > + result = -ENODEV; > + goto remove_dev_link; > + } > > tz->tz_enabled = 1; > > dev_info(&tz->device->dev, "registered as thermal_zone%d\n", > tz->thermal_zone->id); > + > return 0; > + > +remove_dev_link: > + sysfs_remove_link(&tz->thermal_zone->device.kobj, "device"); > +remove_tz_link: > + sysfs_remove_link(&tz->device->dev.kobj, "thermal_zone"); > +unregister_tzd: > + thermal_zone_device_unregister(tz->thermal_zone); > + > + return result; > } > > static void acpi_thermal_unregister_thermal_zone(struct acpi_thermal *tz) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel