From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BCACC433E1 for ; Fri, 29 May 2020 20:44:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4073C2075A for ; Fri, 29 May 2020 20:44:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RwvHsL3u" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4073C2075A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=22eY810k7LDW6nFkCX+i72a20DzwP4MxZKZxhCgK5UU=; b=RwvHsL3uxIEQLP 4nNZ8/0rRG1xdzMMqPuteE+q8xDiqmLnE+sukhyKjVL+OSVmVF2VBbgS+aRc7aViZwOvKTS8h/BAX ZsTDVVcOxG8u+KNOxFDussgftW+aUYqXVDJJeLIxH0S8Nj+/wnf1sDuEWmjvnpEfYrCBd0HzypmQy HNBO7hLASTuX9YGzI0ZLiJDjIhq/beXRywCx+H8NorFw5YHAyvstWBZkLi+n2AuCKlfFiCZQkDHnE Uf6WLIJQfLPH4nM9t9Yr3flu2sJTzj6GTcMPj4KoaEDgYFUMWuDLSu+xIpZsuPv38TJnQlX4IHZMz XO1jbSMwub1gIX0Kmyfg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jelrO-0001Hf-FH; Fri, 29 May 2020 20:44:10 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jelrM-0001Gf-54 for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 20:44:09 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 5A3ED8030; Fri, 29 May 2020 20:44:57 +0000 (UTC) Date: Fri, 29 May 2020 13:44:04 -0700 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition Message-ID: <20200529204404.GW37466@atomide.com> References: <20200529201701.521933-1-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200529201701.521933-1-arnd@arndb.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_134408_230026_E161619C X-CRM114-Status: UNSURE ( 8.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: linux-kernel@vger.kernel.org, Stefan Agner , soc@kernel.org, Olof Johansson , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [200529 20:18]: > There is one more regression introduced by the last build fix: Argh.. I did run make randconfig for like 10 builds after the last fix. > arch/arm/mach-omap2/timer.c:170:6: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] > void __init omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/common.h:118:20: note: previous definition is here > static inline void omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/timer.c:170:13: error: redefinition of 'omap5_realtime_timer_init' > void __init omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/common.h:118:20: note: previous definition is here > static inline void omap5_realtime_timer_init(void) > > Address this by removing the now obsolete #ifdefs in that file and > just building the entire file based on the flag that controls the > omap5_realtime_timer_init function declaration. I think this will introduce other randconfig build failures as SOC_HAS_REALTIME_COUNTER is bool in Kconfig. We still need to call omap5_realtime_timer_init() even if SOC_HAS_REALTIME_COUNTER is not set. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel