From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85E05C433DF for ; Fri, 29 May 2020 21:14:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 427AF206A4 for ; Fri, 29 May 2020 21:14:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="b/BtHC41" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 427AF206A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9scJnfntZIF1o4s6wufGNKqvjNtRxoFrKk0g0qWRuUI=; b=b/BtHC41eL98At lD6/8CTyC5N2S/oeLCRAZb3pFL5MuO1HX5eXI9Hqv5CBEypl8TCU+utr41SUDEhm7wVDe/4Hxc0ga 0ErleZYJih2GmGnnbJNyCES5q+yDBIPee994YqeIGjCpapjoHnBj4zEpKkpUMQVgAndUrlAqckM+8 57GsVoUt3u0f54en26FxX8EXIDmyr7a280opY3yfhFhlDIq0htrkaWPo60ZoaF4fAlX3rmxMwY/bJ asm/WTefduz4b2JVZirheJEeIsOSMTGpl8Vu/U+i/1OTzsCgaILETPl13dre48OPAQgeBGA0x8CEZ t1eD0AV90mowT3ssNqLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jemL0-0004BF-Rh; Fri, 29 May 2020 21:14:46 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jemKx-0004Aa-Jw for linux-arm-kernel@lists.infradead.org; Fri, 29 May 2020 21:14:44 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A2B6C8030; Fri, 29 May 2020 21:15:33 +0000 (UTC) Date: Fri, 29 May 2020 14:14:40 -0700 From: Tony Lindgren To: Arnd Bergmann Subject: Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition Message-ID: <20200529211440.GX37466@atomide.com> References: <20200529201701.521933-1-arnd@arndb.de> <20200529204404.GW37466@atomide.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200529_141443_695499_31F30898 X-CRM114-Status: GOOD ( 14.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , List-Id: Cc: "linux-kernel@vger.kernel.org" , Stefan Agner , SoC Team , Olof Johansson , linux-omap , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Arnd Bergmann [200529 21:09]: > On Fri, May 29, 2020 at 10:44 PM Tony Lindgren wrote: > > > > * Arnd Bergmann [200529 20:18]: > > > There is one more regression introduced by the last build fix: > > > > Argh.. I did run make randconfig for like 10 builds > > after the last fix. > > > > > Address this by removing the now obsolete #ifdefs in that file and > > > just building the entire file based on the flag that controls the > > > omap5_realtime_timer_init function declaration. > > > > I think this will introduce other randconfig build failures > > as SOC_HAS_REALTIME_COUNTER is bool in Kconfig. > > I did a few hundred randconfig builds with the patch and have > not yet seen any further problems. Ah right, it works for randconfig builds now but won't boot :) > > We still need to call omap5_realtime_timer_init() even if > > SOC_HAS_REALTIME_COUNTER is not set. > > This is what's in the header file: > > #ifdef CONFIG_SOC_HAS_REALTIME_COUNTER > extern void omap5_realtime_timer_init(void); > #else > static inline void omap5_realtime_timer_init(void) > { > } > #endif > > In fact, the inline stub is what that caused the regression, > so I think it's ok with my patch. To me it seems not having SOC_HAS_REALTIME_COUNTER will cause omap5_realtime_timer_init() not get called? That initializes clocks and calls timer_probe(). So this will result in non-booting system AFAIK, the header file stub should no rely CONFIG_SOC_HAS_REALTIME_COUNTER also, but rather ! CONFIG_SOC_OMAP5 || CONFIG_SOC_DRA7XX. Also the Makefile change at least seems wrong, that can't rely on CONFIG_SOC_HAS_REALTIME_COUNTER. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel