From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: alexandre.belloni@bootlin.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver
Date: Tue, 2 Jun 2020 08:06:50 +0200 [thread overview]
Message-ID: <20200602060650.vlfx26qb57sewcjw@sekiro> (raw)
In-Reply-To: <20200531154017.04fc727f@archlinux>
On Sun, May 31, 2020 at 03:40:17PM +0100, Jonathan Cameron wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Mon, 25 May 2020 13:27:44 +0300
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
> > Since changes can come from all sort of places, it may make sense to have
> > this symbol as a dependency to make sure that the 'make allmodconfig' &&
> > 'make allyesconfig' build rules cover this driver as well for a
> > compile-build/test.
> >
> > It seemed useful [recently] when trying to apply a change for this.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Makes sense. Given this sort of change can expose weird an wonderful
> dependencies that were previously hidden, I'll be wanting an
> ack from at91 people.
Agree.
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Regards
Ludovic
>
> Jonathan
>
> > ---
> > drivers/iio/adc/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> > index c48c00077775..c1f4c0aec265 100644
> > --- a/drivers/iio/adc/Kconfig
> > +++ b/drivers/iio/adc/Kconfig
> > @@ -294,7 +294,7 @@ config ASPEED_ADC
> >
> > config AT91_ADC
> > tristate "Atmel AT91 ADC"
> > - depends on ARCH_AT91
> > + depends on ARCH_AT91 || COMPILE_TEST
> > depends on INPUT && SYSFS
> > select IIO_BUFFER
> > select IIO_TRIGGERED_BUFFER
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-02 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 10:27 [PATCH] iio: Kconfig: at91_adc: add COMPILE_TEST dependency to driver Alexandru Ardelean
2020-05-31 14:40 ` Jonathan Cameron
2020-06-02 6:06 ` Ludovic Desroches [this message]
2020-06-06 14:26 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200602060650.vlfx26qb57sewcjw@sekiro \
--to=ludovic.desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandru.ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox