From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6253C433E0 for ; Tue, 2 Jun 2020 16:03:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 767422065C for ; Tue, 2 Jun 2020 16:03:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OArjTktO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 767422065C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f4Vas9WeEfdvCBqdmN/CA8jxThC+xkOEUvfRugl9AcI=; b=OArjTktOSxSu4l mq0zDfDhjYOaY3Q2iDfvUcs39nG1LaxYDynvoEU55TJfrs/XzUxPXXhjzj/GXu7gnHy1w7lazmF9D 1PYhZk6UzzptogJu9afzh3ViDk7u48Rb34H0ZszXEs0rR081lT7IUF7BFHE/RY2+/M7y61lNnF41/ dqMyNbVwseaJ/cILbJ3016dY+SEK1GZSyN3JKxxUZgYjpcoKMPPnThHiIg40EILkbzk/V8rxvDiZ2 ss+mbY3xBET+6kkxgXsH3aoKjDk2r/1kJwB5u1HKAb/tYFe/0h3Qx9KiuogRt+T/Yl+3ElLhbPH6U b7AWR7I16NHPOQYFaA2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg9Nw-0006dq-8H; Tue, 02 Jun 2020 16:03:28 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jg9Ns-0006Sy-NA; Tue, 02 Jun 2020 16:03:26 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 3A7392A2941; Tue, 2 Jun 2020 17:03:23 +0100 (BST) Date: Tue, 2 Jun 2020 18:03:20 +0200 From: Boris Brezillon To: Miquel Raynal Subject: Re: [PATCH v9 5/9] mtd: nand: Convert generic NAND bits to use the ECC framework Message-ID: <20200602180320.6539adb0@collabora.com> In-Reply-To: <20200602143124.29553-6-miquel.raynal@bootlin.com> References: <20200602143124.29553-1-miquel.raynal@bootlin.com> <20200602143124.29553-6-miquel.raynal@bootlin.com> Organization: Collabora X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200602_090324_886913_B1AFFEC1 X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2 Jun 2020 16:31:20 +0200 Miquel Raynal wrote: > Embed a generic NAND ECC high-level object in the nand_device > structure to carry all the ECC engine configuration/data. > > Signed-off-by: Miquel Raynal > --- > drivers/mtd/nand/raw/nand_base.c | 4 +++- > include/linux/mtd/nand.h | 12 ++++++------ > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > index e8e22d79f422..ed0f642be993 100644 > --- a/drivers/mtd/nand/raw/nand_base.c > +++ b/drivers/mtd/nand/raw/nand_base.c > @@ -5984,7 +5984,9 @@ static int nand_scan_tail(struct nand_chip *chip) > /* ECC sanity check: warn if it's too weak */ > if (!nand_ecc_strength_good(chip)) > pr_warn("WARNING: %s: the ECC used on your system (%db/%dB) is too weak compared to the one required by the NAND chip (%db/%dB)\n", > - mtd->name, chip->ecc.strength, chip->ecc.size, > + mtd->name, > + nanddev_get_ecc_conf(&chip->base)->strength, > + nanddev_get_ecc_conf(&chip->base)->step_size, Hm, are you sure all places using chip->ecc.{strength,size} have been patched to use nanddev_get_ecc_conf()? > nanddev_get_ecc_requirements(&chip->base)->strength, > nanddev_get_ecc_requirements(&chip->base)->step_size); > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index 0b89da54bef2..668c99c4aaa7 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -290,7 +290,7 @@ struct nand_ecc { > * struct nand_device - NAND device > * @mtd: MTD instance attached to the NAND device > * @memorg: memory layout > - * @eccreq: ECC requirements > + * @ecc: NAND ECC object attached to the NAND device > * @rowconv: position to row address converter > * @bbt: bad block table info > * @ops: NAND operations attached to the NAND device > @@ -298,8 +298,8 @@ struct nand_ecc { > * Generic NAND object. Specialized NAND layers (raw NAND, SPI NAND, OneNAND) > * should declare their own NAND object embedding a nand_device struct (that's > * how inheritance is done). > - * struct_nand_device->memorg and struct_nand_device->eccreq should be filled > - * at device detection time to reflect the NAND device > + * struct_nand_device->memorg and struct_nand_device->ecc.requirements should > + * be filled at device detection time to reflect the NAND device > * capabilities/requirements. Once this is done nanddev_init() can be called. > * It will take care of converting NAND information into MTD ones, which means > * the specialized NAND layers should never manually tweak > @@ -308,7 +308,7 @@ struct nand_ecc { > struct nand_device { > struct mtd_info mtd; > struct nand_memory_organization memorg; > - struct nand_ecc_props eccreq; > + struct nand_ecc ecc; > struct nand_row_converter rowconv; > struct nand_bbt bbt; > const struct nand_ops *ops; > @@ -519,7 +519,7 @@ nanddev_get_memorg(struct nand_device *nand) > static inline const struct nand_ecc_props * > nanddev_get_ecc_conf(struct nand_device *nand) > { > - return &nand->eccreq; > + return &nand->ecc.ctx.conf; > } > > /** > @@ -530,7 +530,7 @@ nanddev_get_ecc_conf(struct nand_device *nand) > static inline const struct nand_ecc_props * > nanddev_get_ecc_requirements(struct nand_device *nand) > { > - return &nand->eccreq; > + return &nand->ecc.requirements; > } > > int nanddev_init(struct nand_device *nand, const struct nand_ops *ops, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel