[soc:baikal/drivers-1 4/5] drivers/bus/bt1-apb.c:330:3: error: implicit declaration of function 'readl'

[soc:baikal/drivers-1 4/5] drivers/bus/bt1-apb.c:330:3: error: implicit declaration of function 'readl'

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1995 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git baikal/drivers-1
head:   83ca8b3e8f213f49cc68b5c1fbcf88ebb24671eb
commit: 8f93662d8324940e8925a0e492c587dbcf7c7fee [4/5] bus: Add Baikal-T1 APB-bus driver
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 8f93662d8324940e8925a0e492c587dbcf7c7fee
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>, old ones prefixed by <<):

drivers/bus/bt1-apb.c: In function 'inject_error_store':
>> drivers/bus/bt1-apb.c:330:3: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
330 |   readl(apb->res);
|   ^~~~~
cc1: some warnings being treated as errors

vim +/readl +330 drivers/bus/bt1-apb.c

   318	
   319	static ssize_t inject_error_store(struct device *dev,
   320				      struct device_attribute *attr,
   321				      const char *data, size_t count)
   322	{
   323		struct bt1_apb *apb = dev_get_drvdata(dev);
   324	
   325		/*
   326		 * Either dummy read from the unmapped address in the APB IO area
   327		 * or manually set the IRQ status.
   328		 */
   329		if (!strncmp(data, "nodev", 5))
 > 330			readl(apb->res);
   331		else if (!strncmp(data, "irq", 3))
   332			regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
   333					   APB_EHB_ISR_PENDING);
   334		else
   335			return -EINVAL;
   336	
   337		return count;
   338	}
   339	static DEVICE_ATTR_RW(inject_error);
   340	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 62590 bytes --]

[-- Attachment #3: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [soc:baikal/drivers-1 4/5] drivers/bus/bt1-apb.c:330:3: error: implicit declaration of function 'readl'

[Serge Semin]

On Wed, Jun 03, 2020 at 07:21:26AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git baikal/drivers-1
> head:   83ca8b3e8f213f49cc68b5c1fbcf88ebb24671eb
> commit: 8f93662d8324940e8925a0e492c587dbcf7c7fee [4/5] bus: Add Baikal-T1 APB-bus driver
> config: sparc64-allyesconfig (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 8f93662d8324940e8925a0e492c587dbcf7c7fee
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc64 
> 

> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>, old ones prefixed by <<):
> 
> drivers/bus/bt1-apb.c: In function 'inject_error_store':
> >> drivers/bus/bt1-apb.c:330:3: error: implicit declaration of function 'readl' [-Werror=implicit-function-declaration]
> 330 |   readl(apb->res);
> |   ^~~~~
> cc1: some warnings being treated as errors

That branch lacks of fixup commits available in the for-next and baikal/drivers
branches. So it is redundant, since it has got only the initial BT1
APB/AXI commits. Following up fixups haven't been merged in there, which cause
the warning.

-Sergey

> 
> vim +/readl +330 drivers/bus/bt1-apb.c
> 
>    318	
>    319	static ssize_t inject_error_store(struct device *dev,
>    320				      struct device_attribute *attr,
>    321				      const char *data, size_t count)
>    322	{
>    323		struct bt1_apb *apb = dev_get_drvdata(dev);
>    324	
>    325		/*
>    326		 * Either dummy read from the unmapped address in the APB IO area
>    327		 * or manually set the IRQ status.
>    328		 */
>    329		if (!strncmp(data, "nodev", 5))
>  > 330			readl(apb->res);
>    331		else if (!strncmp(data, "irq", 3))
>    332			regmap_update_bits(apb->regs, APB_EHB_ISR, APB_EHB_ISR_PENDING,
>    333					   APB_EHB_ISR_PENDING);
>    334		else
>    335			return -EINVAL;
>    336	
>    337		return count;
>    338	}
>    339	static DEVICE_ATTR_RW(inject_error);
>    340	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel