From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22402C433E0 for ; Wed, 3 Jun 2020 10:30:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E80D520679 for ; Wed, 3 Jun 2020 10:30:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qF13H7HQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E80D520679 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+HI0pvQn1wzgtDmJmGjIumqjJj1RcIAdXW274TYVWtA=; b=qF13H7HQBskcD4 dyCQZlpW28lAmiTZvin2VbJJUpHhI+tdwRMIiyZmLeohhMBoXk//ikiMwWE6c7Iik2yix3u5hqmTA LtbUxJgBvGL0k5Zfz74vz70wzUV+3ouM0jGgn0maMxfHQaZcf1nSbrZx/L5aLn6QtejgoEiHELY9R k5pPGwcCNW2MY6pGe7BTfkrPMP5fGJW+nwBapbuRoVTNDIdnO6jadn3VztyZ1qdzttj4ZbWaED37n 78X9pnxw4NphZb7WVkG2XkScCE7zy9hGJfZbSHQsEJ2wGqlb6a2bf4sN5HqnTstlG1u8bgt9skzFJ UoUbKQj6yDdyB/lrlvag==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgQfS-0000ke-KY; Wed, 03 Jun 2020 10:30:42 +0000 Received: from relay7-d.mail.gandi.net ([217.70.183.200]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgQfO-0000hk-79; Wed, 03 Jun 2020 10:30:39 +0000 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 5CC3F20006; Wed, 3 Jun 2020 10:30:34 +0000 (UTC) Date: Wed, 3 Jun 2020 12:30:32 +0200 From: Miquel Raynal To: Boris Brezillon Subject: Re: [PATCH v9 4/9] mtd: rawnand: Use nanddev_get_ecc_requirements() when relevant Message-ID: <20200603123032.0c70b9fd@xps13> In-Reply-To: <20200602180016.2adefd73@collabora.com> References: <20200602143124.29553-1-miquel.raynal@bootlin.com> <20200602143124.29553-5-miquel.raynal@bootlin.com> <20200602180016.2adefd73@collabora.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200603_033038_412312_2879D462 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Tudor Ambarus , Julien Su , Richard Weinberger , linux-mtd@lists.infradead.org, Thomas Petazzoni , Mason Yang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Boris Brezillon wrote on Tue, 2 Jun 2020 18:00:16 +0200: > On Tue, 2 Jun 2020 16:31:19 +0200 > Miquel Raynal wrote: > > > > diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c > > index 1ce2cbe72e4c..e8e22d79f422 100644 > > --- a/drivers/mtd/nand/raw/nand_base.c > > +++ b/drivers/mtd/nand/raw/nand_base.c > > @@ -4725,6 +4725,9 @@ static inline bool is_full_id_nand(struct nand_flash_dev *type) > > static bool find_full_id_nand(struct nand_chip *chip, > > struct nand_flash_dev *type) > > { > > + struct nand_device *base = &chip->base; > > + struct nand_ecc_props *requirements = > > + (struct nand_ecc_props *)nanddev_get_ecc_requirements(base); > > Ouch, that sounds wrong. How about introducing a > nanddev_set_ecc_requirements() helper instead? The same applies to all > places where you have this cast. A setter helper is very helpful here, I should have done that in the first place. > > > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > > index e572d1600f63..0b89da54bef2 100644 > > --- a/include/linux/mtd/nand.h > > +++ b/include/linux/mtd/nand.h > > @@ -527,7 +527,7 @@ nanddev_get_ecc_conf(struct nand_device *nand) > > * device > > * @nand: NAND device > > */ > > -const struct nand_ecc_props * > > +static inline const struct nand_ecc_props * > > nanddev_get_ecc_requirements(struct nand_device *nand) > > Looks like this should be squashed in patch 2. > > > { > > return &nand->eccreq; > Oh right. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel