* [arm64:devel/mte-v4 25/28] arch/arm64/kernel/cpufeature.c:137:5: warning: no previous prototype for 'mte_ftr_filter'
@ 2020-06-03 13:31 kernel test robot
2020-06-03 15:29 ` Catalin Marinas
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-06-03 13:31 UTC (permalink / raw)
To: Vincenzo, Frascino,; +Cc: Catalin Marinas, kbuild-all, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 4302 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git devel/mte-v4
head: 628f92bb11400cab1adb95c32c05cb1c3c384248
commit: bcf807ed1e622f8311b05e34816df6c41aed54c0 [25/28] arm64: mte: Kconfig entry
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout bcf807ed1e622f8311b05e34816df6c41aed54c0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> arch/arm64/kernel/cpufeature.c:137:5: warning: no previous prototype for 'mte_ftr_filter' [-Wmissing-prototypes]
137 | s64 mte_ftr_filter(const struct arm64_ftr_bits *ftrp, s64 val)
| ^~~~~~~~~~~~~~
vim +/mte_ftr_filter +137 arch/arm64/kernel/cpufeature.c
4225028da943ad3 Catalin Marinas 2020-05-15 136
22fba7c9a015db8 Catalin Marinas 2020-04-08 @137 s64 mte_ftr_filter(const struct arm64_ftr_bits *ftrp, s64 val)
22fba7c9a015db8 Catalin Marinas 2020-04-08 138 {
22fba7c9a015db8 Catalin Marinas 2020-04-08 139 struct device_node *np;
22fba7c9a015db8 Catalin Marinas 2020-04-08 140 static bool memory_checked = false;
22fba7c9a015db8 Catalin Marinas 2020-04-08 141 static bool mte_capable = true;
22fba7c9a015db8 Catalin Marinas 2020-04-08 142
4225028da943ad3 Catalin Marinas 2020-05-15 143 if (mte_disable)
4225028da943ad3 Catalin Marinas 2020-05-15 144 return ID_AA64PFR1_MTE_NI;
4225028da943ad3 Catalin Marinas 2020-05-15 145
22fba7c9a015db8 Catalin Marinas 2020-04-08 146 /* EL0-only MTE is not supported by Linux, don't expose it */
22fba7c9a015db8 Catalin Marinas 2020-04-08 147 if (val < ID_AA64PFR1_MTE)
22fba7c9a015db8 Catalin Marinas 2020-04-08 148 return ID_AA64PFR1_MTE_NI;
22fba7c9a015db8 Catalin Marinas 2020-04-08 149
22fba7c9a015db8 Catalin Marinas 2020-04-08 150 if (memory_checked)
22fba7c9a015db8 Catalin Marinas 2020-04-08 151 return mte_capable ? val : ID_AA64PFR1_MTE_NI;
22fba7c9a015db8 Catalin Marinas 2020-04-08 152
22fba7c9a015db8 Catalin Marinas 2020-04-08 153 if (!acpi_disabled) {
22fba7c9a015db8 Catalin Marinas 2020-04-08 154 pr_warn("MTE not supported on ACPI systems\n");
22fba7c9a015db8 Catalin Marinas 2020-04-08 155 return ID_AA64PFR1_MTE_NI;
22fba7c9a015db8 Catalin Marinas 2020-04-08 156 }
22fba7c9a015db8 Catalin Marinas 2020-04-08 157
22fba7c9a015db8 Catalin Marinas 2020-04-08 158 /* check the DT "memory" nodes for MTE support */
22fba7c9a015db8 Catalin Marinas 2020-04-08 159 for_each_node_by_type(np, "memory") {
22fba7c9a015db8 Catalin Marinas 2020-04-08 160 memory_checked = true;
22fba7c9a015db8 Catalin Marinas 2020-04-08 161 mte_capable &= of_property_read_bool(np, "arm,armv8.5-memtag");
22fba7c9a015db8 Catalin Marinas 2020-04-08 162 }
22fba7c9a015db8 Catalin Marinas 2020-04-08 163
22fba7c9a015db8 Catalin Marinas 2020-04-08 164 if (!memory_checked || !mte_capable) {
22fba7c9a015db8 Catalin Marinas 2020-04-08 165 pr_warn("System memory is not MTE-capable\n");
22fba7c9a015db8 Catalin Marinas 2020-04-08 166 memory_checked = true;
22fba7c9a015db8 Catalin Marinas 2020-04-08 167 mte_capable = false;
22fba7c9a015db8 Catalin Marinas 2020-04-08 168 return ID_AA64PFR1_MTE_NI;
22fba7c9a015db8 Catalin Marinas 2020-04-08 169 }
22fba7c9a015db8 Catalin Marinas 2020-04-08 170
22fba7c9a015db8 Catalin Marinas 2020-04-08 171 return val;
22fba7c9a015db8 Catalin Marinas 2020-04-08 172 }
22fba7c9a015db8 Catalin Marinas 2020-04-08 173 #endif
22fba7c9a015db8 Catalin Marinas 2020-04-08 174
:::::: The code at line 137 was first introduced by commit
:::::: 22fba7c9a015db8fbbb8004e8f82b10767d98de5 arm64: mte: Check the DT memory nodes for MTE support
:::::: TO: Catalin Marinas <catalin.marinas@arm.com>
:::::: CC: Catalin Marinas <catalin.marinas@arm.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 71821 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [arm64:devel/mte-v4 25/28] arch/arm64/kernel/cpufeature.c:137:5: warning: no previous prototype for 'mte_ftr_filter'
2020-06-03 13:31 [arm64:devel/mte-v4 25/28] arch/arm64/kernel/cpufeature.c:137:5: warning: no previous prototype for 'mte_ftr_filter' kernel test robot
@ 2020-06-03 15:29 ` Catalin Marinas
0 siblings, 0 replies; 2+ messages in thread
From: Catalin Marinas @ 2020-06-03 15:29 UTC (permalink / raw)
To: kernel test robot; +Cc: Vincenzo, Frascino, , kbuild-all, linux-arm-kernel
On Wed, Jun 03, 2020 at 09:31:38PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git devel/mte-v4
> head: 628f92bb11400cab1adb95c32c05cb1c3c384248
> commit: bcf807ed1e622f8311b05e34816df6c41aed54c0 [25/28] arm64: mte: Kconfig entry
> config: arm64-allyesconfig (attached as .config)
> compiler: aarch64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout bcf807ed1e622f8311b05e34816df6c41aed54c0
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>, old ones prefixed by <<):
>
> >> arch/arm64/kernel/cpufeature.c:137:5: warning: no previous prototype for 'mte_ftr_filter' [-Wmissing-prototypes]
> 137 | s64 mte_ftr_filter(const struct arm64_ftr_bits *ftrp, s64 val)
> | ^~~~~~~~~~~~~~
>
> vim +/mte_ftr_filter +137 arch/arm64/kernel/cpufeature.c
Thanks for the report, it should indeed be a static function. I'll fix
it locally but in v5 I'll drop the DT patch altogether.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-03 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-03 13:31 [arm64:devel/mte-v4 25/28] arch/arm64/kernel/cpufeature.c:137:5: warning: no previous prototype for 'mte_ftr_filter' kernel test robot
2020-06-03 15:29 ` Catalin Marinas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).