From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09BB4C433DF for ; Thu, 4 Jun 2020 08:59:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20CE2074B for ; Thu, 4 Jun 2020 08:59:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QP23wWio" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20CE2074B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=13eqKRwOF1ij9YXWPZmJMG4MEB9H9qbb+YDXNVGgkpQ=; b=QP23wWioJ8FFHl DMnBc+5y+vF5L8Tsemqa3B2PKWY9d3obYCFLgHOpSdCMX26peNJoJeoWo8qqtyZ4/oFLv7mKxTs6o GMSphKcv7ndnu06MNY2p5F31Tdt029VVFae2HcmeguwJRIpswzcXl/+M9MOsT0KEtMkgepGbV8dEb 4vyVC4FaGGp64EDP1CrxHGJVnrHnxkvRbj61n9ElPyPPIaQT7GUhnQZ5N1VuxkzSso+gK3O+e5RXX lRozyczEKmB9GlWTooLmlbTOjbo5edED+aLiwZHK05m5gUR9pnPn865UKIvZsmisl7Sn14AnrMhI0 A1lRLpI5x3bUQgb/Gzvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jglis-0000fQ-Aj; Thu, 04 Jun 2020 08:59:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgliq-0000ef-2Y for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 08:59:37 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4748F55D; Thu, 4 Jun 2020 01:59:35 -0700 (PDT) Received: from bogus (unknown [10.37.12.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9DC643F6CF; Thu, 4 Jun 2020 01:59:33 -0700 (PDT) Date: Thu, 4 Jun 2020 09:59:31 +0100 From: Sudeep Holla To: Guenter Roeck Subject: Re: [PATCH] arm: dts: vexpress: Move mcc node back into motherboard node Message-ID: <20200604085931.GB8814@bogus> References: <20200603194614.GA187107@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200603194614.GA187107@roeck-us.net> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_015936_157940_E55A9E32 X-CRM114-Status: GOOD ( 16.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lorenzo Pieralisi , Rob Herring , Andre Przywara , Liviu Dudau , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 03, 2020 at 12:46:14PM -0700, Guenter Roeck wrote: > On Wed, Jun 03, 2020 at 05:22:37PM +0100, Andre Przywara wrote: > > Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices > > out of bus node") moved the "mcc" DT node into the root node, because > > it does not have any children using "reg" properties, so does violate > > some dtc checks about "simple-bus" nodes. > > However this broke the vexpress config-bus code, which walks up the > > device tree to find the first node with an "arm,vexpress,site" property. > > This gave the wrong result (matching the root node instead of the > > motherboard node), so broke the clocks and some other devices for > > VExpress boards. > > > > Move the whole node back into its original position. This re-introduces > > the dtc warning, but is conceptually the right thing to do. The dtc > > warning seems to be overzealous here, there are discussions on fixing or > > relaxing this check instead. > > > > Fixes: d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") > > Signed-off-by: Andre Przywara > > Tested-by: Guenter Roeck > Thanks, I have added your Reported-by along with this. By the way, this email seem to have broken the link. Initially thought b4 is getting confused, but checked the lore.kernel.org too to confirm. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel