From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Linus Walleij <linus.walleij@linaro.org>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Joe Perches <joe@perches.com>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken
Date: Thu, 4 Jun 2020 15:30:38 +0300 [thread overview]
Message-ID: <20200604123038.GG22511@kadam> (raw)
In-Reply-To: <alpine.DEB.2.21.2006041328570.2577@hadrien>
On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote:
> OK, I recall a discussion with Dan where he suggested that some things
> that were not actually bug fixes could also merit a Fixes tag. But it's
> probably better if he weighs in directly.
I generally think Fixes should only be used for "real bug" fixes.
The one exception is when I'm reviewing a patch that fixes an "unused
assignment" static checker warning is that I know which commit
introduced the warning. I don't have strong feelings if it's in the
Fixes tag or if it's just mentioned in the commit message. But it
helps me when I'm reviewing if I don't have to grovel through git
history myself. Also I think that it's always a good exercise for
people fixing patches to look at how the bug was introduced.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-04 12:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 7:37 [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Christophe JAILLET
2020-06-01 8:58 ` Robert Jarzmik
2020-06-01 11:31 ` Christophe JAILLET
2020-06-01 18:31 ` Dan Carpenter
2020-06-03 22:08 ` Linus Walleij
2020-06-04 8:31 ` Dan Carpenter
2020-06-04 9:17 ` Joe Perches
2020-06-04 9:52 ` Julia Lawall
2020-06-04 10:00 ` Joe Perches
2020-06-04 10:33 ` Julia Lawall
2020-06-04 11:08 ` Joe Perches
2020-06-04 11:42 ` Julia Lawall
2020-06-04 12:30 ` Dan Carpenter [this message]
2020-06-04 16:08 ` Joe Perches
2020-06-04 16:29 ` Julia Lawall
2020-06-04 17:35 ` Dan Carpenter
2020-06-04 18:02 ` Joe Perches
2020-06-03 22:05 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604123038.GG22511@kadam \
--to=dan.carpenter@oracle.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=joe@perches.com \
--cc=julia.lawall@inria.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).