From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FC5BC433E0 for ; Thu, 4 Jun 2020 12:31:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32993206C3 for ; Thu, 4 Jun 2020 12:31:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="J3tFr3Md"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="fbwz9OjA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32993206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S1jo9ROdhoLTXCKjwbCler0z5XvYYx0hCRs9fJz9ztM=; b=J3tFr3MdvrnwuO 0aAKcrYxy/IIliZMOkVtUGdj8DLYILP03unxjWakn04jqEofOi60echSgw9gUtbXleG2j9qNVFjc+ 8CUqBIKlylmB7KEfRr80ul8eKdBt5nEtq6HA+zBXtCS6xj6QbHJZOSGfz8bdyDyEcc0t1OOAxhLFF CFxUL3qAZwF479yxlQcz3TBn52MgXdIEo6yfoiWly/o+Tg1qGmX2cbHRXZ9GfJRUw3QLZCQDVo2MA A9T6mO/E7iafoEjs/ykqmC2hLk2n7miMxjIA31eU6A/1iwdOVkq2219eLkXShsklnQx5tim7aFO1s GNHrUjVXiKbLFIJiR3Wg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgp1T-000384-HY; Thu, 04 Jun 2020 12:31:03 +0000 Received: from aserp2120.oracle.com ([141.146.126.78]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgp1Q-00037X-E6 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 12:31:01 +0000 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 054CGWMQ169869; Thu, 4 Jun 2020 12:30:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=p50nfK6c0axXgdD+SiJnP8v0Oz8oiv+sqt/hvkFeNoo=; b=fbwz9OjAIC1zG3T7hrypOKrzqF5niOCCEq4QDRimlzjtXE6va0WnNZXOKlYpkV6GaCxN CSi614YXQOvjhURSN+MuKR9FNNCnkk51VTpjUDKHaC8fV45QO2dW68MH5oN976eyBiYu o4svG+LlSHir/yLNhwRg1tWsFICMjY2XvJZgeV53DjCV4lag301x2+MIbCY4kzrTzLxf p0ZSYkcL8lObe3rfgdc75jfFhJhhhA4xYtreVRengsV9Fsa559i4wDnix6xdkH36RujZ XWZO/6AJm5Vv1wonW7UAyLRychnX3yyt8fhZkNVdit2nmtGhftY2Uy4RCjkWmnBGOzLx xg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 31evap1dpy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 04 Jun 2020 12:30:50 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 054CE48u123956; Thu, 4 Jun 2020 12:30:50 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 31c25v543f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 04 Jun 2020 12:30:50 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 054CUlxV008967; Thu, 4 Jun 2020 12:30:48 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 04 Jun 2020 05:30:47 -0700 Date: Thu, 4 Jun 2020 15:30:38 +0300 From: Dan Carpenter To: Julia Lawall Subject: Re: [PATCH] pinctrl: pxa: pxa2xx: Remove 'pxa2xx_pinctrl_exit()' which is unused and broken Message-ID: <20200604123038.GG22511@kadam> References: <20200601183102.GS30374@kadam> <20200604083120.GF22511@kadam> <2aa49a543e6f48a6f428a37b63a06f9149870225.camel@perches.com> <32232229031e02edcc268b1074c9bac44012ee35.camel@perches.com> <10e54ee84bd44171ef329bed9e7e6a946bae61ba.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006040086 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 phishscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006040086 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_053100_563072_70EDA5BA X-CRM114-Status: GOOD ( 14.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , kernel-janitors@vger.kernel.org, "linux-kernel@vger.kernel.org" , Haojian Zhuang , "open list:GPIO SUBSYSTEM" , Christophe JAILLET , Linux ARM , Joe Perches , Robert Jarzmik , Daniel Mack Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 04, 2020 at 01:42:12PM +0200, Julia Lawall wrote: > OK, I recall a discussion with Dan where he suggested that some things > that were not actually bug fixes could also merit a Fixes tag. But it's > probably better if he weighs in directly. I generally think Fixes should only be used for "real bug" fixes. The one exception is when I'm reviewing a patch that fixes an "unused assignment" static checker warning is that I know which commit introduced the warning. I don't have strong feelings if it's in the Fixes tag or if it's just mentioned in the commit message. But it helps me when I'm reviewing if I don't have to grovel through git history myself. Also I think that it's always a good exercise for people fixing patches to look at how the bug was introduced. regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel