From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56550C433DF for ; Thu, 4 Jun 2020 13:58:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2502C207D0 for ; Thu, 4 Jun 2020 13:58:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RtkggPv6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uGZWLY/9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2502C207D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Pp7IMrrZTKCsbslhTvAXsJjseNEJqv9QaC8Mj2dN+OQ=; b=RtkggPv6vPwHtZ JZ8qcwNX2s0fzeKC1LKHr8aUQX2u0asJaie6zi32DN/mYdPK6l7AMYcjafVsFyBcUjXOn2Ha9+FzG BPIBFtoyGYMOcuohhvZOOw++KyvSq+qR6ibRs0jAfKjHgjqg8mb+K7jntdnw6MXlQ1fBslsS2sEvC 8WHMeBIn07GwVm+OGHY2CkrhE/+t2iOkjVZNIx1Ns3ZfPlFyDvT7sLy/NjridG1n1AMjNJ2Jun+J1 CHjXdrxZxCWl2gwRABltbwAKocQP27P9OuiubGlzKZpGQEBSEz8IEB/Uv0xTUisVbw5Om3no6+Ejj k55KzHD/Q5VSNL4WbTeA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgqNv-0005xx-VH; Thu, 04 Jun 2020 13:58:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jgqNt-0005wx-9V for linux-arm-kernel@lists.infradead.org; Thu, 04 Jun 2020 13:58:18 +0000 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DCCA020772; Thu, 4 Jun 2020 13:58:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591279094; bh=NECwl9V9eUPjMiBKm4/NUElVNzAVswrtLb5Ash6AmNw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uGZWLY/90X3PHBwBJBECC5AEfkkUvXvRftsarwbHRlL1ye5SM0NXKjjA7fXltKfGL /httPXwbNmxOx61CMzCyRmmNhJ4+zpJaCMxhkZyxsAuEoa42eK0fxNKhxjslhbGNOe FH0d0K3cWhCZARJdAG4cZYTOH1PPjLcVIF1yjwFA= Date: Thu, 4 Jun 2020 14:58:06 +0100 From: Will Deacon To: Alexander Popov Subject: Re: [PATCH 5/5] gcc-plugins/stackleak: Don't instrument vgettimeofday.c in arm64 VDSO Message-ID: <20200604135806.GA3170@willie-the-truck> References: <20200604134957.505389-1-alex.popov@linux.com> <20200604134957.505389-6-alex.popov@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200604134957.505389-6-alex.popov@linux.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200604_065817_352536_94DD17B4 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-hardening@lists.openwall.com, Catalin Marinas , Masahiro Yamada , Vincenzo Frascino , Sven Schnelle , Naohiro Aota , Masahiro Yamada , x86@kernel.org, Emese Revfy , Iurii Zaikin , PaX Team , Laura Abbott , Mathias Krause , Kees Cook , linux-kbuild@vger.kernel.org, Alexander Monakov , Michal Marek , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, notify@kernel.org, Florian Weimer , gcc@gcc.gnu.org, Brad Spengler , linux-kernel@vger.kernel.org, Miguel Ojeda , Luis Chamberlain , Jessica Yu , Andrew Morton , Thiago Jung Bauermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 04, 2020 at 04:49:57PM +0300, Alexander Popov wrote: > Don't try instrumenting functions in arch/arm64/kernel/vdso/vgettimeofday.c. > Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin > is disabled. > > Signed-off-by: Alexander Popov > --- > arch/arm64/kernel/vdso/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/vdso/Makefile b/arch/arm64/kernel/vdso/Makefile > index 3862cad2410c..9b84cafbd2da 100644 > --- a/arch/arm64/kernel/vdso/Makefile > +++ b/arch/arm64/kernel/vdso/Makefile > @@ -32,7 +32,8 @@ UBSAN_SANITIZE := n > OBJECT_FILES_NON_STANDARD := y > KCOV_INSTRUMENT := n > > -CFLAGS_vgettimeofday.o = -O2 -mcmodel=tiny -fasynchronous-unwind-tables > +CFLAGS_vgettimeofday.o = -O2 -mcmodel=tiny -fasynchronous-unwind-tables \ > + $(DISABLE_STACKLEAK_PLUGIN) I can pick this one up via arm64, thanks. Are there any other plugins we should be wary of? It looks like x86 filters out $(GCC_PLUGINS_CFLAGS) when building the vDSO. Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel