From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: suzuki.poulose@arm.com, peterz@infradead.org,
coresight@lists.linaro.org, linux-kernel@vger.kernel.org,
acme@kernel.org, mingo@redhat.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/1] perf: cs-etm: Allow no CoreSight sink to be specified on command line
Date: Thu, 4 Jun 2020 15:21:39 -0600 [thread overview]
Message-ID: <20200604212139.GE18961@xps15> (raw)
In-Reply-To: <20200526105310.9706-2-mike.leach@linaro.org>
On Tue, May 26, 2020 at 11:53:10AM +0100, Mike Leach wrote:
> Adjust the handling of the session sink selection to allow no sink to
> be selected on the command line. This then forwards the sink selection to
> the CoreSight infrastructure which will attempt to select a sink based
> on the default sink select priorities.
>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> ---
> tools/perf/arch/arm/util/cs-etm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c
> index 941f814820b8..ed9ea2c60f27 100644
> --- a/tools/perf/arch/arm/util/cs-etm.c
> +++ b/tools/perf/arch/arm/util/cs-etm.c
> @@ -242,10 +242,10 @@ static int cs_etm_set_sink_attr(struct perf_pmu *pmu,
> }
>
> /*
> - * No sink was provided on the command line - for _now_ treat
> - * this as an error.
> + * No sink was provided on the command line - allow the CoreSight
> + * system to look for a default
> */
> - return ret;
> + return 0;
Leo added a tested-by for this patch. As I wrote on a previous patch we are
currently in the middle of the merge window and as such this set needs to be
rebased on v5.8-rc1 (when it comes out) and sent again.
Thanks,
Mathieu
> }
>
> static int cs_etm_recording_options(struct auxtrace_record *itr,
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-06-04 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 10:53 [PATCH v4 0/1] perf: cs_etm: Allow no sink on command line Mike Leach
2020-05-26 10:53 ` [PATCH v4 1/1] perf: cs-etm: Allow no CoreSight sink to be specified " Mike Leach
2020-06-04 21:21 ` Mathieu Poirier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200604212139.GE18961@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=acme@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox