From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643FDC433DF for ; Fri, 5 Jun 2020 14:09:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 34F8B2074B for ; Fri, 5 Jun 2020 14:09:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LFXO85o/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 34F8B2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pfU/0PoNEfp/H44yXnSDGPtFO6HjOzSpF3Yjw33PFBA=; b=LFXO85o/EdsyRf iLBf6CluZYLcudeUD0zMghMGrbMD5oefmOdAyFCb+YhpfHS9XYWbzM43BIE+lgP1hLPT1SuVw/h9y +pwj0JiF7N32OROmJBmnsU6ZE72GExSK9xOk9wBlf1T9nFFugEdx4k6OmKXoOU64tcRvz7cQ+Ncs4 msuWfqzTRogYVFgl22+PwWqRk3cPd8H4pm4zDGVo56/vOiNNUljGgJvjbgvhemNjj/ACb6SaCazxG 1C8eonHpXwTGRHHPgMg5g0qW0WT9gRii/OXtZw6mgU3qKu69rN/g3acK4DXgGoNF162aMH1LvTLQV JncrcJvK/YK3KSesUAbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhD27-0005Lf-Hv; Fri, 05 Jun 2020 14:09:19 +0000 Received: from mga11.intel.com ([192.55.52.93]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhD22-0005LJ-Qe for linux-arm-kernel@lists.infradead.org; Fri, 05 Jun 2020 14:09:16 +0000 IronPort-SDR: +pcYmFaUw/9rx/4LHiE+CeDBn0CJmdrFWZqh+4Ez0okveQHFLsfFxfpOkTgaaILk90Tvx6zq9L CH4f4f5k3e4g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jun 2020 07:09:14 -0700 IronPort-SDR: STm5cJBEx3cZwh5EDl1WI2zIniez547qsBBHLm0a+PZkJql6UaV6R0I9F6DqWusAPQO2MUnztk j822dzBvILJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,476,1583222400"; d="scan'208";a="471924635" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005.fm.intel.com with ESMTP; 05 Jun 2020 07:09:09 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jhD1z-00B2nb-Cy; Fri, 05 Jun 2020 17:09:11 +0300 Date: Fri, 5 Jun 2020 17:09:11 +0300 From: Andy Shevchenko To: Guenter Roeck Subject: Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog Message-ID: <20200605140911.GO2428291@smile.fi.intel.com> References: <20200604211039.12689-1-michael@walle.cc> <20200604211039.12689-5-michael@walle.cc> <8f042c2442852c29519c381833f3d289@walle.cc> <871a4990-5b94-3a17-01d4-74998375f08b@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <871a4990-5b94-3a17-01d4-74998375f08b@roeck-us.net> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_070914_879474_DECDACE5 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linus Walleij , Thierry Reding , Lee Jones , Jason Cooper , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-pwm@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Rob Herring , Thomas Gleixner , Wim Van Sebroeck , linux-arm Mailing List , linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , Linux Kernel Mailing List , Li Yang , Michael Walle , Mark Brown , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: > On 6/5/20 3:50 AM, Andy Shevchenko wrote: > > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > >> Am 2020-06-05 10:14, schrieb Andy Shevchenko: > >>> On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: ... > >>>> +static bool nowayout = WATCHDOG_NOWAYOUT; > >>>> +module_param(nowayout, bool, 0); > >>>> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started > >>>> (default=" > >>>> + __MODULE_STRING(WATCHDOG_NOWAYOUT) > >>>> ")"); > >>>> + > >>>> +static int timeout; > >>>> +module_param(timeout, int, 0); > >>>> +MODULE_PARM_DESC(timeout, "Initial watchdog timeout in seconds"); > >>> > >>> Guenter ACKed this, but I'm wondering why we still need module > >>> parameters... > >> > >> How would a user change the nowayout or the timeout? For the latter > >> there is > >> a device tree entry, but thats not easy changable by the user. > > > > Yes, it's more question to VIm and Guenter than to you. > > > > Has support for providing module parameters with the kernel command line > been discontinued/deprecated, or did it run out of favor ? Sorry if I > missed that. Latter according to Greg KH. One of the (plenty) examples [1]. [1]: https://www.mail-archive.com/driverdev-devel@linuxdriverproject.org/msg96495.html > nowayout has a configuration default. A module parameter is sometimes > provided by drivers to be able to override it. The timeout provided > via devicetree or on the command line is only the initial/default > timeout, and the watchdog daemon can change it after opening the > watchdog device as it sees fit. Thanks for explanation. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel