From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2ECBC433E1 for ; Fri, 5 Jun 2020 15:05:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2BC420659 for ; Fri, 5 Jun 2020 15:05:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="H9j/9fIl"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FhMZXa0p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2BC420659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Q/d9PtacY7qF6zTw1NjiEEyUlkkvAT9ApXcXyBOUgZY=; b=H9j/9fIlN3UdpM 3TI8cZqxh+1rdJjVbjmHRiVOIzIs0nHmJswT2xyz8YTWvN7wyQ5NtO3povaEg5ER4WLmXJJRY6B5T 5xePiInlmJLery66pCzpRp5prsJo116xPW6tB7JJjKC7XTo1wwPzUdXeBk5/o4ZzlEKzAhxmnglqk B+4LKHe5nFIaTfDjItooG+saoYxFFMWRzD1+syve+WP4JoHwMrFI2rQ/Hud7SjkjzaZPzHyyjFSOI 7WWN1UU3q3Jh/QMjf1dZ0LOsHKGzkkxWoF6OYfAVSJBSrYbrZVXHJbS1XLT+Kdi3VBy/G+HVr+Iwc OthPIWdl8tw++oaGDVHQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhDur-0003gW-B6; Fri, 05 Jun 2020 15:05:53 +0000 Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jhDuo-0003fU-2p for linux-arm-kernel@lists.infradead.org; Fri, 05 Jun 2020 15:05:51 +0000 Received: by mail-pj1-x1042.google.com with SMTP id ne5so224787pjb.5 for ; Fri, 05 Jun 2020 08:05:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zl3uXlckh/ILLSJmP4ICOMWaZeDZ9A0z1FTiwzLjSyw=; b=FhMZXa0pqbczzolzAxUWZ6l/cPlMoh4ca88ZnP72F5OYEn3zDPmaVkLsEhS4wZ+pb0 OpUlPrw60Tua/44wX2E7hmR3oq/UIlBkX6MCzdidGL3xYk4Tk8eeCL6xZHOKj9vNCrAg guhsG/zT5eSHPtpXuIhpIMM6uloPsYE3bXwLAHewQdvx6qHVnWyuxAWjQ1fz3ckzVPDS 5pUVso6Z2RoHxEz39lci25KPw6abx1Zkuq+KXgPKXiTANRvNBOou8K8pTFA0bYezdf9z TzKSMnbwvC/WXnzd6T9MMZ40cgzcmMVsVtAsAsviiHakm4fgNulNY9awZsOEFrTAdlAl USFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=zl3uXlckh/ILLSJmP4ICOMWaZeDZ9A0z1FTiwzLjSyw=; b=fSrudNsBIAUiEU4mpLguDravObQiUWSn2ugLIwNMVkOC+721KHh2a8YCQ5ub35cLTt cxbFmlSG9ecZHdaa8mO7v6wnTh96L4A+0fDB/CoC5QRu0b7HNjtpUYpM/yZkG9CNu4a5 1ZI3A6jW0rEkjOlWTY0l/x18C6DvnJqy+Ivu0bFPRllEBypBfoTFMWIbogixoetWBbRh lolGbSevUF78/XOiOrcc7OsFC+310RBFIwy6kf37Sma5djg05QmqKBOq9BBZCa+vYanO aWJn9KBxTK3sBRFaiYEUxTEG5U6MpVrJtxMc9staR80GhVDueRRszbgrJnZfeneW39yP 3/9Q== X-Gm-Message-State: AOAM533nN516XxJDD1fu45mTYnTl/oQoVMivu1u3/XjSKYl5EXABJNMp oE1FHOEXp4DFtZgaM5JybAg= X-Google-Smtp-Source: ABdhPJyEI1zMv/msQyU+Ei4KhuaGEwq9i+HpH2+fhygN3bHJuK30LAKFw+2tG0snVq8JEO8lyyXIig== X-Received: by 2002:a17:90a:20c2:: with SMTP id f60mr3704149pjg.29.1591369548704; Fri, 05 Jun 2020 08:05:48 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 5sm3155367pfc.143.2020.06.05.08.05.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jun 2020 08:05:44 -0700 (PDT) Date: Fri, 5 Jun 2020 08:05:42 -0700 From: Guenter Roeck To: Andy Shevchenko Subject: Re: [PATCH v4 04/11] watchdog: add support for sl28cpld watchdog Message-ID: <20200605150542.GA254229@roeck-us.net> References: <20200604211039.12689-1-michael@walle.cc> <20200604211039.12689-5-michael@walle.cc> <8f042c2442852c29519c381833f3d289@walle.cc> <871a4990-5b94-3a17-01d4-74998375f08b@roeck-us.net> <20200605140911.GO2428291@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200605140911.GO2428291@smile.fi.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200605_080550_145516_0E6EB95E X-CRM114-Status: GOOD ( 17.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Linus Walleij , Thierry Reding , Lee Jones , Jason Cooper , Marc Zyngier , Bartosz Golaszewski , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-pwm@vger.kernel.org, Jean Delvare , linux-watchdog@vger.kernel.org, "open list:GPIO SUBSYSTEM" , Rob Herring , Thomas Gleixner , Wim Van Sebroeck , linux-arm Mailing List , linux-hwmon@vger.kernel.org, Greg Kroah-Hartman , Linux Kernel Mailing List , Li Yang , Michael Walle , Mark Brown , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 05, 2020 at 05:09:11PM +0300, Andy Shevchenko wrote: > On Fri, Jun 05, 2020 at 06:52:00AM -0700, Guenter Roeck wrote: > > On 6/5/20 3:50 AM, Andy Shevchenko wrote: > > > On Fri, Jun 5, 2020 at 1:24 PM Michael Walle wrote: > > >> Am 2020-06-05 10:14, schrieb Andy Shevchenko: > > >>> On Fri, Jun 5, 2020 at 12:14 AM Michael Walle wrote: > > ... > > > >>>> +static bool nowayout = WATCHDOG_NOWAYOUT; > > >>>> +module_param(nowayout, bool, 0); > > >>>> +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started > > >>>> (default=" > > >>>> + __MODULE_STRING(WATCHDOG_NOWAYOUT) > > >>>> ")"); > > >>>> + > > >>>> +static int timeout; > > >>>> +module_param(timeout, int, 0); > > >>>> +MODULE_PARM_DESC(timeout, "Initial watchdog timeout in seconds"); > > >>> > > >>> Guenter ACKed this, but I'm wondering why we still need module > > >>> parameters... > > >> > > >> How would a user change the nowayout or the timeout? For the latter > > >> there is > > >> a device tree entry, but thats not easy changable by the user. > > > > > > Yes, it's more question to VIm and Guenter than to you. > > > > > > > Has support for providing module parameters with the kernel command line > > been discontinued/deprecated, or did it run out of favor ? Sorry if I > > missed that. > > Latter according to Greg KH. One of the (plenty) examples [1]. > > [1]: https://www.mail-archive.com/driverdev-devel@linuxdriverproject.org/msg96495.html > What is the suggested replacement ? Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel