From: kernel test robot <lkp@intel.com>
To: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org
Subject: [arm:clearfog 9/10] drivers/pci/pcie/portdrv_core.c:328 pcie_port_device_register() warn: inconsistent indenting
Date: Fri, 5 Jun 2020 17:59:08 +0800 [thread overview]
Message-ID: <202006051706.ZS4Wck9h%lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 2832 bytes --]
tree: git://git.armlinux.org.uk/~rmk/linux-arm.git clearfog
head: 8db1590173dd1c6bb6861ca938663938c1d832b8
commit: 5315e38eefb72a8444314ef491b730b99baed319 [9/10] mvebu/clearfog pcie updates
config: x86_64-randconfig-m001-20200605 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
New smatch warnings:
drivers/pci/pcie/portdrv_core.c:328 pcie_port_device_register() warn: inconsistent indenting
Old smatch warnings:
drivers/pci/pcie/portdrv_core.c:341 pcie_port_device_register() warn: inconsistent indenting
vim +328 drivers/pci/pcie/portdrv_core.c
308
309 /**
310 * pcie_port_device_register - register PCI Express port
311 * @dev: PCI Express port to register
312 *
313 * Allocate the port extension structure and register services associated with
314 * the port.
315 */
316 int pcie_port_device_register(struct pci_dev *dev)
317 {
318 int status, capabilities, i, nr_service;
319 int irqs[PCIE_PORT_DEVICE_MAXSERVICES];
320
321 /* Enable PCI Express port device */
322 status = pci_enable_device(dev);
323 if (status)
324 return status;
325
326 /* Get and check PCI Express port services */
327 capabilities = get_port_device_capability(dev);
> 328 dev_info(&dev->dev, "PCIe capabilities: 0x%x\n", capabilities);
329 if (!capabilities)
330 return 0;
331
332 pci_set_master(dev);
333 /*
334 * Initialize service irqs. Don't use service devices that
335 * require interrupts if there is no way to generate them.
336 * However, some drivers may have a polling mode (e.g. pciehp_poll_mode)
337 * that can be used in the absence of irqs. Allow them to determine
338 * if that is to be used.
339 */
340 status = pcie_init_service_irqs(dev, irqs, capabilities);
341 dev_info(&dev->dev, "init_service_irqs: %d\n", status);
342 if (status) {
343 capabilities &= PCIE_PORT_SERVICE_HP;
344 if (!capabilities)
345 goto error_disable;
346 }
347
348 /* Allocate child services if any */
349 status = -ENODEV;
350 nr_service = 0;
351 for (i = 0; i < PCIE_PORT_DEVICE_MAXSERVICES; i++) {
352 int service = 1 << i;
353 if (!(capabilities & service))
354 continue;
355 if (!pcie_device_init(dev, service, irqs[i]))
356 nr_service++;
357 }
358 if (!nr_service)
359 goto error_cleanup_irqs;
360
361 return 0;
362
363 error_cleanup_irqs:
364 pci_free_irq_vectors(dev);
365 error_disable:
366 pci_disable_device(dev);
367 return status;
368 }
369
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31951 bytes --]
[-- Attachment #3: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2020-06-05 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 9:59 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-04 3:17 [arm:clearfog 9/10] drivers/pci/pcie/portdrv_core.c:328 pcie_port_device_register() warn: inconsistent indenting kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006051706.ZS4Wck9h%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox