From: Sudeep Holla <sudeep.holla@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, james.quinlan@broadcom.com,
Jonathan.Cameron@Huawei.com, dave.martin@arm.com,
lukasz.luba@arm.com
Subject: Re: [PATCH v8 3/9] firmware: arm_scmi: Add notification dispatch and delivery
Date: Mon, 8 Jun 2020 18:03:46 +0100 [thread overview]
Message-ID: <20200608170346.GD13622@bogus> (raw)
In-Reply-To: <20200520081118.54897-4-cristian.marussi@arm.com>
On Wed, May 20, 2020 at 09:11:12AM +0100, Cristian Marussi wrote:
> Add core SCMI Notifications dispatch and delivery support logic which is
> able, at first, to dispatch well-known received events from the RX ISR to
> the dedicated deferred worker, and then, from there, to final deliver the
> events to the registered users' callbacks.
>
> Dispatch and delivery is just added here, still not enabled.
>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> drivers/firmware/arm_scmi/notify.c | 354 ++++++++++++++++++++++++++++-
> drivers/firmware/arm_scmi/notify.h | 10 +
> 2 files changed, 362 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/notify.c b/drivers/firmware/arm_scmi/notify.c
> index 7cf61dbe2a8e..d582f71fde5b 100644
> --- a/drivers/firmware/arm_scmi/notify.c
> +++ b/drivers/firmware/arm_scmi/notify.c
[...]
> @@ -1085,6 +1422,12 @@ int scmi_notification_init(struct scmi_handle *handle)
> ni->gid = gid;
> ni->handle = handle;
>
> + ni->notify_wq = alloc_workqueue("scmi_notify",
> + WQ_UNBOUND | WQ_FREEZABLE | WQ_SYSFS,
> + 0);
What's the use of WQ_SYSFS for SCMI notifications ? Do we need it ?
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-08 17:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 8:11 [PATCH v8 0/9] SCMI Notifications Core Support Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 1/9] firmware: arm_scmi: Add notification protocol-registration Cristian Marussi
2020-06-08 17:02 ` Sudeep Holla
2020-06-16 19:58 ` Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 2/9] firmware: arm_scmi: Add notification callbacks-registration Cristian Marussi
2020-06-08 17:03 ` Sudeep Holla
2020-06-17 23:20 ` Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 3/9] firmware: arm_scmi: Add notification dispatch and delivery Cristian Marussi
2020-06-08 17:03 ` Sudeep Holla [this message]
2020-06-17 23:31 ` Cristian Marussi
2020-06-18 8:37 ` Lukasz Luba
2020-05-20 8:11 ` [PATCH v8 4/9] firmware: arm_scmi: Enable notification core Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 5/9] firmware: arm_scmi: Add Power notifications support Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 6/9] firmware: arm_scmi: Add Perf " Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 7/9] firmware: arm_scmi: Add Sensor " Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 8/9] firmware: arm_scmi: Add Reset " Cristian Marussi
2020-05-20 8:11 ` [PATCH v8 9/9] firmware: arm_scmi: Add Base " Cristian Marussi
2020-06-08 17:02 ` Sudeep Holla
2020-06-18 17:24 ` Cristian Marussi
2020-06-08 17:05 ` [PATCH v8 0/9] SCMI Notifications Core Support Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608170346.GD13622@bogus \
--to=sudeep.holla@arm.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=cristian.marussi@arm.com \
--cc=dave.martin@arm.com \
--cc=james.quinlan@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox