From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99F3C433E0 for ; Tue, 9 Jun 2020 19:15:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D9212067B for ; Tue, 9 Jun 2020 19:15:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lL3Ekqs9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eHah8lXm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D9212067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5/p/vBrr5qGifeS33wdCpl9WosmR+3GbHnwawcu5QTg=; b=lL3Ekqs9GuMzmD YB9bgelDN5f+BwXuwUGGNLjFCYl7JZ/aMbEorul102s7cKxoyfpjFW8EPNXgQ0CcwppjbvqNOhKe5 P+7ZT7/8vixB91T+3/5LeP3BQx9KBHDBJ7dDgW6RY/wXCZbGhy+QiPGbRwx47mHKJv8hvw7ocq5F2 uivkwzCvjApUx/7sDRATLdKG7HMokhdm89+8ANTYIss7BcILu7Zu1CZwGuHlnmDXyvoRQX8nXubot pWQFc2HUCb7w+hX52NaMDZqhBpyC2FrowsrDvllRPhU+yhzVx/q8LR3tlIAOaw6DmYkZiSrSkbqik NO9h1SBLdjwa+U9c14lw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jijiI-0003Y2-TN; Tue, 09 Jun 2020 19:15:10 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jijiF-0002Pw-BS for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 19:15:08 +0000 Received: by mail-pg1-x543.google.com with SMTP id s10so10761750pgm.0 for ; Tue, 09 Jun 2020 12:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tGGQ3VocRYuP1AxRJCcf0YOuFdAQhDzmAD+bQaR7nDA=; b=eHah8lXm/9NdioI0IQB1zdteauOgwpHoUWv7l0ccJihSiEXHjtaYGtLsa46BXQHRf7 Yv5rlSSlQSgQ0xLs6A13uJrWkHUd4+wvxefc11Rip7Zheaq+tjhgPtKEc60jT/XwgsLw pO9xQmpan/wYr/eEowfxeA5uFIlinxoaAc56M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tGGQ3VocRYuP1AxRJCcf0YOuFdAQhDzmAD+bQaR7nDA=; b=TWFwgE1muiJHKvVTpUXsvKGupxmSOeFwEY9q1ADIwSUIBkdxJFAFwo/kBhs6s4zzHz XDbkbkUzuW31TeBWkzuNgf/V0gsCZLfbHeiMHJENY89eIzhork6lwewPNU5hguppTr2R 3X/bCUv3ae0l5kVxNrmgMHFK/wS5bjvAW2qM1EHtdHpuR1hCEumikuNd81tSf6L590fX itYc8zTPgLkQqt64u3+G3L78bGen7UlKq9WmXocKTluDq1+iFEcUGpm6qXbBulT7ffLZ zZaWbJX4X2xU15RHe4ZSSvZegX5R31NaZ7N3cqgEQmlx2OOCxQyN/zGLCxZgVuVSzO4b xYyQ== X-Gm-Message-State: AOAM532ZMkmn+FaIW/Sz5rnJBPL2tflFOkd1FZb+xGiRlxGOpTkOuayV 9gHiQZcXPbZFUJLLRFcrM11jXQ== X-Google-Smtp-Source: ABdhPJyMccFgBeerGRwQ2wfXEHGAf89Obho1rWhLY+bGl8E1JBTsrHPd/c8CjkZ038Wze8SEwIszmQ== X-Received: by 2002:a63:2248:: with SMTP id t8mr25901047pgm.113.1591730105075; Tue, 09 Jun 2020 12:15:05 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q18sm8933851pgn.34.2020.06.09.12.15.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 12:15:04 -0700 (PDT) Date: Tue, 9 Jun 2020 12:15:02 -0700 From: Kees Cook To: Alexander Popov Subject: Re: [PATCH 0/5] Improvements of the stackleak gcc plugin Message-ID: <202006091210.C139883AB@keescook> References: <20200604134957.505389-1-alex.popov@linux.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200604134957.505389-1-alex.popov@linux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_121507_424960_92201EA6 X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-hardening@lists.openwall.com, Catalin Marinas , Masahiro Yamada , Vincenzo Frascino , Will Deacon , Naohiro Aota , Sven Schnelle , Masahiro Yamada , x86@kernel.org, Emese Revfy , Iurii Zaikin , PaX Team , Laura Abbott , Mathias Krause , linux-kbuild@vger.kernel.org, Alexander Monakov , Michal Marek , Thomas Gleixner , Peter Collingbourne , linux-arm-kernel@lists.infradead.org, notify@kernel.org, Florian Weimer , gcc@gcc.gnu.org, Brad Spengler , linux-kernel@vger.kernel.org, Miguel Ojeda , Luis Chamberlain , Jessica Yu , Andrew Morton , Thiago Jung Bauermann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 04, 2020 at 04:49:52PM +0300, Alexander Popov wrote: > In this patch series I collected various improvements of the stackleak > gcc plugin. Thanks! > Alexander Popov (5): > gcc-plugins/stackleak: Exclude alloca() from the instrumentation logic > gcc-plugins/stackleak: Use asm instrumentation to avoid useless > register saving These look like they might need tweaks (noted in their separate replies). > gcc-plugins/stackleak: Add 'verbose' plugin parameter > gcc-plugins/stackleak: Don't instrument itself If you wanted to reorder the series and move these first, I could take these into my tree right away (they're logically separate from the other fixes). > gcc-plugins/stackleak: Don't instrument vgettimeofday.c in arm64 VDSO This seems good -- though I'm curious about 32-bit ARM and the other HAVE_GCC_PLUGINS architectures with vDSOs (which appears to be all of them except um). -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel