From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC6A1C433E0 for ; Tue, 9 Jun 2020 14:16:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B62D0206D5 for ; Tue, 9 Jun 2020 14:16:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PADQXqD9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B62D0206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=72UnHvt5nyJtXWaXr/K0blbm59myyYkBZPJJlElrihw=; b=PADQXqD9HJvJBr m3STZfse5BLxmxOHc5aTic8xo3GiH2iglJgm9qg4qmSAnYRwAm1QkW3jiriwZ4jPkT176KQ6QQZ1q fTrLz2kR9vMtpZj/VUJfLOWyeakJi9Gafp2C48sdqN77UnrPnlSvU2xOcHy1ViDZNurrtHttyTK/e JbXKwsgjMkPhnI6e6IO4BQCW+r8ny7osB8Sy80hfq62WICciijn3g4qWQzeKb+a1XKahyxN+2xPC3 jvPlWIkYiz2HKx++MZrr7eN0/LiOGGkHVj8Ye/0LyAJrc92nA64gaszZvm1xr1EHapviekTw8h70A 8A2+fGJQmxU/1aakOgJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jif3E-0003aw-Us; Tue, 09 Jun 2020 14:16:28 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jif3B-0003aM-4J for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 14:16:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01A661FB; Tue, 9 Jun 2020 07:16:24 -0700 (PDT) Received: from arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD27A3F66F; Tue, 9 Jun 2020 07:16:22 -0700 (PDT) Date: Tue, 9 Jun 2020 15:16:20 +0100 From: Dave Martin To: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH v2 5/6] prctl.2: Add PR_PAC_RESET_KEYS (arm64) Message-ID: <20200609141620.GC25945@arm.com> References: <1590614258-24728-1-git-send-email-Dave.Martin@arm.com> <1590614258-24728-6-git-send-email-Dave.Martin@arm.com> <1084d017-54f3-475c-be1b-aabc801d9a71@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1084d017-54f3-475c-be1b-aabc801d9a71@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_071625_264205_EC978669 X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-man@vger.kernel.org, Catalin Marinas , Amit Daniel Kachhap , Mark Rutland , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 09, 2020 at 01:36:42PM +0200, Michael Kerrisk (man-pages) wrote: > Hello Dave, > > I've applied this patch (manually, because 4/6 is not yet applied). > I have a question below. > > On 5/27/20 11:17 PM, Dave Martin wrote: > > Add documentation for the PR_PAC_RESET_KEYS ioctl added in Linux > > 5.0 for arm64. > > > > Signed-off-by: Dave Martin > > Cc: Will Deacon > > Cc: Catalin Marinas > > Cc: Amit Daniel Kachhap > > Cc: Mark Rutland > > > > --- > > > > Since v1: > > > > * Clarify explicitly that PR_PAC_RESET_KEYS is redundant when combined > > with execve(). > > > > * Move error condition details into the prctl description, to avoid > > excessive duplication while keeping keeping related pieces of text > > closer together. > > > > * In lieu of having a separate man page to cross reference for detailed > > guidance, cross-reference the kernel documentation. > > > > * Add safety warning. This is deliberately vague, pending ongoing > > discussions with libc folks. > > --- > > man2/prctl.2 | 80 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > > > [...] > > > +.IP > > +.B Warning: > > +Because the compiler or run-time environment > > +may be using some or all of the keys, > > +a successful > > Things got a bit garbled here. I think the next few lines should have been > at the end. > > +.IP > > +For more information, see the kernel source file > > +.I Documentation/arm64/pointer\-authentication.rst > > +.\"commit b693d0b372afb39432e1c49ad7b3454855bc6bed > > +(or > > +.I Documentation/arm64/pointer\-authentication.txt > > +before Linux 5.3). > > +.B PR_PAC_RESET_KEYS > > +may crash the calling process. > > +The conditions for using it safely are complex and system-dependent. > > +Don't use it unless you know what you are doing. > > I applied the following change after your patch; is it okay? > > .IP > .B Warning: > Because the compiler or run-time environment > may be using some or all of the keys, > a successful Looks fine, execpt that I think you need to move the .B PR_PAC_RESET_KEYS line here also. Thanks ---Dave > +may crash the calling process. > +The conditions for using it safely are complex and system-dependent. > +Don't use it unless you know what you are doing. > .IP > For more information, see the kernel source file > .I Documentation/arm64/pointer\-authentication.rst > @@ -1020,9 +1023,6 @@ For more information, see the kernel source file > .I Documentation/arm64/pointer\-authentication.txt > before Linux 5.3). > .B PR_PAC_RESET_KEYS > -may crash the calling process. > -The conditions for using it safely are complex and system-dependent. > -Don't use it unless you know what you are doing. > .\" prctl PR_SET_PDEATHSIG > .TP > .BR PR_SET_PDEATHSIG " (since Linux 2.1.57)" > [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel