From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA61EC433E1 for ; Tue, 9 Jun 2020 18:06:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B419B20691 for ; Tue, 9 Jun 2020 18:06:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cD0Gp4+Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B419B20691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cZBMi0JGW6xD8ziL6JvyNRZCB4ldOCMVwKRYjFwYkIs=; b=cD0Gp4+ZokMWBn jS/WZTnSsXSowL6RIt69kSsGwrqatCBec6KtL5MFI0ciuuKeI8VnNiSUpqL0mo4XI4zGbrDblSwkC hj3WHjKe9CIYvtxOe2Lin1ueZUtLEMID0onDXR6jAki8Ozz3e48i8uMYoZsr3ldVOZtdGMKWbmDoZ ijNKs2QJFluFW2frtehLmlJbfGDwXdXXqel4pTctcxLz6wOz2K9GIIR6kD3atqBAI9J8rPBlgRJiX FqTIJx7Jup/GbvJxdbSRZtb20vhTIo94qezVLISS1coj1nwNB0JPrlQ9/Pj7sxEhsQ+j2WbmRAdUX HRNwY19LjnuI8KV1J4Vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiie1-0007rr-8B; Tue, 09 Jun 2020 18:06:41 +0000 Received: from muru.com ([72.249.23.125]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiidy-0007rK-QW for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2020 18:06:40 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 7D1E68088; Tue, 9 Jun 2020 18:07:26 +0000 (UTC) Date: Tue, 9 Jun 2020 11:06:31 -0700 From: Tony Lindgren To: Drew Fustini Subject: Re: [PATCH v2] pinctrl-single: fix pcs_parse_pinconf() return value Message-ID: <20200609180631.GS37466@atomide.com> References: <20200608125143.GA2789203@x1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200608125143.GA2789203@x1> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200609_110638_908455_AFC41478 X-CRM114-Status: UNSURE ( 7.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grygorii Strashko , Linus Walleij , linux-kernel@vger.kernel.org, Robert Nelson , linux-gpio@vger.kernel.org, Jason Kridner , Haojian Zhuang , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Drew Fustini [200608 12:52]: > This patch causes pcs_parse_pinconf() to return -ENOTSUPP when no > pinctrl_map is added. The current behavior is to return 0 when > !PCS_HAS_PINCONF or !nconfs. Thus pcs_parse_one_pinctrl_entry() > incorrectly assumes that a map was added and sets num_maps = 2. ... > Fixes: 9dddb4df90d1 ("pinctrl: single: support generic pinconf") It would be good to get an ack/tested-by from Haojian for this. The patch looks right to me: Acked-by: Tony Lindgren _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel