From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D40E9C433DF for ; Wed, 10 Jun 2020 19:20:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7E1E2070B for ; Wed, 10 Jun 2020 19:20:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iSb51E9g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7E1E2070B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Oy5i0zalwwxE2tDrzuC1JLaDKz8CjNLBsRyvd6+EFpc=; b=iSb51E9gjHXSli B6CsVA3K1GJCba41gZSkeM/hL/cJTGeVKFijpCOxliWw9LP1RrCW+eTLaOkhNWf8QGwtksHMTeRf+ jGiN6D9TZoxvllRJzaHZEJssQanalfRIyp+3I746R6E14aLsvJ2lTCasnW2OXtZVnKXI9tL361M+U 6Pk03zV2/8mISkB5VQlFCnnnbpuha+xGSCg78Oz3kNmRZDN5ehwKamKWhtHeH4Uvel3Wjg+7BC0qb P1ALD6zSZTa3lOXOr8vCbTHCEUON8LzGpvIlENhb73/zr5OkfigmUnNF2RT+bsZX36xQbP3IfyEGy yfN5rTujetxux6PhNYtw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jj6HF-0006jo-Me; Wed, 10 Jun 2020 19:20:45 +0000 Received: from relay12.mail.gandi.net ([217.70.178.232]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jj6HC-0006j9-IK for linux-arm-kernel@lists.infradead.org; Wed, 10 Jun 2020 19:20:44 +0000 Received: from windsurf.home (lfbn-tou-1-915-109.w86-210.abo.wanadoo.fr [86.210.146.109]) (Authenticated sender: thomas.petazzoni@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id A3EB9200002; Wed, 10 Jun 2020 19:20:38 +0000 (UTC) Date: Wed, 10 Jun 2020 21:20:37 +0200 From: Thomas Petazzoni To: "Shmuel H." Subject: Re: [RFC PATCH] pci: pci-mvebu: setup BAR0 to internal-regs Message-ID: <20200610212037.7fd32a43@windsurf.home> In-Reply-To: References: <20200608144024.1161237-1-sh@tkos.co.il> <20200608214335.156baaaa@windsurf> Organization: Bootlin X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200610_122042_738745_299F7ED1 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baruch Siach , Jason Cooper , linux-pci@vger.kernel.org, Marek =?UTF-8?B?QmVow7pu?= , Chris ackham , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 10 Jun 2020 17:17:15 +0300 "Shmuel H." wrote: > Apparently, the PCIe controller is outside of the internal registers space. No, it is not. It is outside of the internal-regs node in the DT because it needs more "ranges" properties, but the PCIe controller registers *are* within the internal registers window: <0x82000000 0 0x80000 MBUS_ID(0xf0, 0x01) 0x80000 0 0x00002000 0x82000000 0 0x40000 MBUS_ID(0xf0, 0x01) 0x40000 0 0x00002000 0x82000000 0 0x44000 MBUS_ID(0xf0, 0x01) 0x44000 0 0x00002000 0x82000000 0 0x48000 MBUS_ID(0xf0, 0x01) 0x48000 0 0x00002000 > I could try to use a similar code as in > arch/arm/mach-mvebu/pm.c:mvebu_internal_reg_base or get the first child > of "internal-regs" and call of_translate_address on it with one zero cell. > > Do you have a better solution? In mvebu_pcie_map_registers(), we retrieve the address of the PCIe registers for each port. You can take regs.start, round it down to 1 MB, and you'll get your base address. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel