From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>, arnd@arndb.de
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Maxime Ripard <maxime@cerno.tech>
Subject: Re: [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible
Date: Thu, 11 Jun 2020 07:38:09 +0100 [thread overview]
Message-ID: <20200611063809.GW4106@dell> (raw)
In-Reply-To: <20200610194625.3597460-1-robh@kernel.org>
Arnd,
On Wed, 10 Jun 2020, Rob Herring wrote:
> Using 'syscon' alone should be avoided as compatible strings should be
> specific enough to identify the exact set of registers contained. Update
> the schema to ensure at least 2 compatible strings are present.
I'm assuming you're okay with this?
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Maxime Ripard <maxime@cerno.tech>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> FYI, there's 43 cases of this on arm32 in my testing.
>
> Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 19bdaf781853..af7a68051392 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -43,7 +43,8 @@ properties:
>
> - contains:
> const: syscon
> - additionalItems: true
> + minItems: 2
> + maxItems: 4 # Should be enough
>
> reg:
> maxItems: 1
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-06-11 6:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 19:46 [PATCH] dt-bindings: mfd: Ensure 'syscon' has a more specific compatible Rob Herring
2020-06-11 6:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200611063809.GW4106@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).