From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD6FC433E1 for ; Fri, 12 Jun 2020 11:30:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED85F20792 for ; Fri, 12 Jun 2020 11:30:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TRHbRYhp"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="BPPJPbvO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED85F20792 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rnHLT8xORaulL4wvv91S33RKWnsSDjLAWAtB3nnxygY=; b=TRHbRYhpR7zXfQ KDrueCW1PfxCvDnmULQNqvLO7DMt8xNscAQv/C9Cxc5BvG4BHBigd0z9kb7A4OnB6NWLReidR0GxO DJIphym/R0p2h7UbqMH0U6q+F82uZl+zkM399Zbt+PmA8blTErqe7dfR0Aroa2/Be6em3YCVMcz4z fiAHVzgDvFYjxB9bUIeJvK5hW9PsZWlFWYrWP1PmsNZ2ucStSrZNfX8bwe8jq5UmMC+qijwyko1FF eo/8v8hNJ7ZrBdweeBTDlEQ/hPYVZz4X+6/13FC6WlrGxQybO4sY81GuCkhI/JV+t2fH/mxOVn1xW ypZCRyeR2NVqNCSV+r+g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjhtQ-0000X4-Mo; Fri, 12 Jun 2020 11:30:40 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:214:fdff:fe10:1be6]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jjhtN-0000WU-FC for linux-arm-kernel@lists.infradead.org; Fri, 12 Jun 2020 11:30:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=etPHGVYvPw7yw2ygbiMI5MNxWS/RjHHBmbLSJinvfLQ=; b=BPPJPbvODmjIQrnUW1eLG3MI8 MmiCthfkt1Hdtyn/HSY9hCKkDpas84Fqt+nvsYXWDKexRAJBWEinHZKdspRfDwE7Ig5eFUfrFAZNP bauAmpNpZMXsNcOqJQljGkcypGA86h/mqpjRBiwgMfehzxmQqfhnB5Yjed2maatQ59ghRdxsMjsLO 6yGON/9In+kv6jrt8fAP5TOaq3LQ+8g+WUYZPYAeN77Rr1nU6bEUWW/EmtR5UllksU4OXAJwM9Sr6 46OimonqgIi2TUGEAyr6ZdgVgDM5S8n3flbzOok+2Xr+sXSRn8NOVOcpvpPaPHSdiJSsQcnofxVT9 IbazVLegA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44598) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jjhtI-0002jO-3N; Fri, 12 Jun 2020 12:30:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jjhtH-0006Dh-Eb; Fri, 12 Jun 2020 12:30:31 +0100 Date: Fri, 12 Jun 2020 12:30:31 +0100 From: Russell King - ARM Linux admin To: Sascha Hauer Subject: Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes Message-ID: <20200612113031.GI1551@shell.armlinux.org.uk> References: <20200612083847.29942-1-s.hauer@pengutronix.de> <20200612084710.GC1551@shell.armlinux.org.uk> <20200612100114.GE1551@shell.armlinux.org.uk> <20200612101820.GF1551@shell.armlinux.org.uk> <20200612104208.GG1551@shell.armlinux.org.uk> <20200612112213.GH1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200612112213.GH1551@shell.armlinux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200612_043037_504249_94BF1A13 X-CRM114-Status: GOOD ( 10.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 12, 2020 at 12:22:13PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King - ARM Linux admin wrote: > > With the obvious mistakes fixed (extraneous 'i' and lack of default > > case), it seems to still work on Armada 388 Clearfog Pro with 2.5G > > modules. > > ... and the other bug fixed - mvneta_comphy_init() needs to be passed > the interface mode. Unrelated to the patch, has anyone noticed that mvneta's performance seems to have reduced? I've only just noticed it (which makes 2.5Gbps rather pointless). This is iperf between two clearfogs with a 2.5G fibre link: root@clearfog21:~# iperf -V -c fe80::250:43ff:fe02:303%eno2 ------------------------------------------------------------ Client connecting to fe80::250:43ff:fe02:303%eno2, TCP port 5001 TCP window size: 43.8 KByte (default) ------------------------------------------------------------ [ 3] local fe80::250:43ff:fe21:203 port 48928 connected with fe80::250:43ff:fe02:303 port 5001 [ ID] Interval Transfer Bandwidth [ 3] 0.0-10.0 sec 553 MBytes 464 Mbits/sec I checked with Jon Nettleton, and he confirms my recollection that mvneta on Armada 388 used to be able to fill a 2.5Gbps link. If Armada 388 can't manage, then I suspect Armada XP will have worse performance being an earlier revision SoC. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel